Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize ADR-028 #8398

Merged
merged 32 commits into from
Feb 4, 2021
Merged

Finalize ADR-028 #8398

merged 32 commits into from
Feb 4, 2021

Commits on Jan 20, 2021

  1. Finalize ADR-028

    @robert-zaremba
    robert-zaremba committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    7b8173b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into robert/adr-28

    @robert-zaremba
    robert-zaremba authored Jan 20, 2021
    Configuration menu
    Copy the full SHA
    8643cae View commit details
    Browse the repository at this point in the history

  3. added note about Named Accounts

    @robert-zaremba
    robert-zaremba committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    6038410 View commit details
    Browse the repository at this point in the history

  4. Update docs/architecture/adr-028-public-key-addresses.md 

    Co-authored-by: Dev Ojha <[email protected]>
    @ValarDragon
    Alessio Treglia and ValarDragon authored Jan 20, 2021
    Configuration menu
    Copy the full SHA
    aecb45b View commit details
    Browse the repository at this point in the history

  5. add reference to \#8041

    @robert-zaremba
    robert-zaremba committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    9a4e078 View commit details
    Browse the repository at this point in the history

  6. typo fix

    @robert-zaremba
    robert-zaremba committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    bbfb1b7 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Cory <[email protected]>
    @robert-zaremba @clevinson
    robert-zaremba and clevinson authored Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8129844 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. simplification, review updates

    @robert-zaremba
    robert-zaremba committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    2724c7b View commit details
    Browse the repository at this point in the history

  2. date update

    @robert-zaremba
    robert-zaremba committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    8c44486 View commit details
    Browse the repository at this point in the history

  3. update paragraph about proto.MessageName

    @robert-zaremba
    robert-zaremba committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    1557ef5 View commit details
    Browse the repository at this point in the history

  4. remove the module name section - it's described in other section

    @robert-zaremba
    robert-zaremba committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    aaf471b View commit details
    Browse the repository at this point in the history

  5. Update docs/architecture/adr-028-public-key-addresses.md 

    Co-authored-by: Cory <[email protected]>
    @robert-zaremba @clevinson
    robert-zaremba and clevinson authored Jan 22, 2021
    Configuration menu
    Copy the full SHA
    c230c68 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. remove blake2b

    @robert-zaremba
    robert-zaremba committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    9b21ec5 View commit details
    Browse the repository at this point in the history

  2. move some paragraphs to 'Further Discussion'

    @robert-zaremba
    robert-zaremba committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    9550d11 View commit details
    Browse the repository at this point in the history

  3. renames

    @robert-zaremba
    robert-zaremba committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    c0a9b20 View commit details
    Browse the repository at this point in the history

  4. revert and merge 'Multisig Addresses' section

    @robert-zaremba
    robert-zaremba committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    84f57b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Apply suggestions from code review 

    typos

Co-authored-by: Amaury <[email protected]>
    @robert-zaremba @amaury1093
    robert-zaremba and amaury1093 authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    c8fa6cb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into robert/adr-28

    @robert-zaremba
    robert-zaremba authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    3d29aff View commit details
    Browse the repository at this point in the history

  3. add LengthPrefix to Compose definition

    @robert-zaremba
    robert-zaremba committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    e407672 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into robert/adr-28

    Alessio Treglia authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    889b9c5 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. move composing module accounts to a new subsectoin

    @robert-zaremba
    robert-zaremba committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    ab4b9d1 View commit details
    Browse the repository at this point in the history

  2. adding appendix from meeting with Alan

    @robert-zaremba
    robert-zaremba committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    834d997 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. composed addresses: use LengthPrefix before sorting

    @robert-zaremba
    robert-zaremba committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    3ceb0f2 View commit details
    Browse the repository at this point in the history

  2. Update docs/architecture/adr-028-public-key-addresses.md 

    Co-authored-by: Aaron Craelius <[email protected]>
    @robert-zaremba @aaronc
    robert-zaremba and aaronc authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    274efce View commit details
    Browse the repository at this point in the history

  3. Update docs/architecture/adr-028-public-key-addresses.md 

    Co-authored-by: Aaron Craelius <[email protected]>
    @robert-zaremba @aaronc
    robert-zaremba and aaronc authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    461c703 View commit details
    Browse the repository at this point in the history

  4. adding special case for Module Account Addresses

    @robert-zaremba
    robert-zaremba committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    201a19e View commit details
    Browse the repository at this point in the history

  5. limit 'account' word usage

    @robert-zaremba
    robert-zaremba committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    5093022 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. describe submodule derivation

    @robert-zaremba
    robert-zaremba committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    6fb8701 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Add discussion notes for the module addresses + bring back 'account' … 

    …language
    @robert-zaremba
    robert-zaremba committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    eb23aa6 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Aaron Craelius <[email protected]>
    @robert-zaremba @aaronc
    robert-zaremba and aaronc authored Feb 3, 2021
    Configuration menu
    Copy the full SHA
    963b093 View commit details
    Browse the repository at this point in the history

  3. changing back to proposed

    @robert-zaremba
    robert-zaremba committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    c79c796 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into robert/adr-28

    @robert-zaremba
    robert-zaremba authored Feb 3, 2021
    Configuration menu
    Copy the full SHA
    eae740c View commit details
    Browse the repository at this point in the history