launchpad: fix query params on governance votes querier #7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
requested review from
alessio,
clevinson and
ethanfrey
as code owners
Codecov Report
@@ Coverage Diff @@
## launchpad/backports #7624 +/- ##
====================================================
Coverage 50.26% 50.27%
====================================================
Files 338 338
Lines 17560 17560
====================================================
+ Hits 8827 8828 +1
+ Misses 7940 7939 -1
Partials 793 793 |
|
This pull request introduces 1 alert when merging eddee8c into 792c7bc - view on LGTM.com new alerts:
|
anilcse
approved these changes
Oct 22, 2020
fedekunze
suggested changes
Oct 22, 2020
| rest.WriteErrorResponse(w, http.StatusBadRequest, err.Error()) | ||
| return | ||
| } | ||
|
|
||
| res, _, err = cliCtx.QueryWithData("custom/gov/votes", bz) |
There was a problem hiding this comment.
this error is not checked
There was a problem hiding this comment.
It's checked in line 395 ⬇️
There was a problem hiding this comment.
Right, not necessarily - I think you're right Fede
|
@fedekunze yep -> #7589 |
amaury1093
approved these changes
Oct 22, 2020
robert-zaremba
approved these changes
Oct 22, 2020
|
SRM approval is required: @clevinson @ethanfrey |
alessio
suggested changes
Oct 22, 2020
alessio
reviewed
Oct 22, 2020
Also Done. |
alessio
reviewed
Oct 22, 2020
alessio
changed the title
alessio
approved these changes
Oct 22, 2020
fedekunze
approved these changes
Oct 22, 2020
ethanfrey
approved these changes
Oct 22, 2020
| rest.WriteErrorResponse(w, http.StatusBadRequest, err.Error()) | ||
| return | ||
| } | ||
|
|
||
| res, _, err = cliCtx.QueryWithData("custom/gov/votes", bz) |
clevinson
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same issue with #7588 in master branch
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes