Release v0.39.2 #7574

alessio · 2020-10-16T08:09:11Z

Cosmos SDK v0.39.2 Release.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

Replace old actions that don't build anymore.

Backported from #7084 Co-authored-by: Alessio Treglia <[email protected]>

@puneet2019

Fix the command line `keys add` interactive mode that fails when asked to generate new mnemonic. Closes: #7048 From: - #7049 - #7183 Thanks: @puneet2019 @PaddyMc for the patches.

Added a maximum number of iterations (100) to ApproxRoot (and ApproxSqrt) to serve as a hard limit on the number of iterations that the algorithm performs. If the answer converges before the maximum iterations, it returns immediately. Otherwise, if the answer never converges enough to satisfy the primary loop condition, the looping stops after a hundred iterations. Closes: #7038 Co-authored-by: Miguel Dingli <[email protected]>

The release contains a fix for dvsekhvalnov/jose2go#26, which is needed for the file keyring backend to work with go 1.15. From: #7397

Update vuepress/config & package.json to match master. Touch package-lock.json.

…alidation

…dation support denoms custom validation

Update tendermint to 0.33.8, see [1] for more information. [1] golang/go#40618

@RiccardoM

Origin: #7415 Closes: #7385 Thanks: @RiccardoM for the backport.

yun-yeo · 2020-10-21T16:53:40Z

Can you add #7589 PR to backports?

alessio · 2020-10-21T17:45:20Z

Can you add #7589 PR to backports?

Happy to open a PR 👍

yun-yeo · 2020-10-22T03:35:08Z

Can you add #7589 PR to backports?

Happy to open a PR 👍

Is it correct way?
#7624

From: #7589 Closes: #7588 Thanks: @YunSuk-Yeo Co-authored-by: Alessio Treglia <[email protected]>

ethanfrey

Looks good, I approved all those PRs in here.

One minor comment. We typically squash all PRs into one commit when merging, but
c3cc14c ... 3101928 all come from one pr to allow emoji token names. Maybe we squash them before merging into release?

The output of the version --long command now shows the list of build dependencies. From: #7848 Closes: #7835

Closes: #7894

alessio · 2020-11-13T19:06:35Z

Alright, release notes seem to be final. I'm taggint v0.39.2-rc1. Now we need testing

CHANGELOG.md

alessio · 2020-11-16T12:12:33Z

ACK received from Commerc.io: commercionetwork/commercionetwork#177

We still await more feedback.

Co-authored-by: Alessio Treglia <[email protected]>

tac0turtle · 2020-11-18T13:39:21Z

ci fix is here: #7969

fedekunze · 2020-11-18T15:37:23Z

also relevant #7971

alessio · 2020-11-18T18:12:16Z

ACK received from Terra, see terra-money/classic-core#430

* launchpad: bump tendermint to v0.33.9 * update release notes Co-authored-by: Alessio Treglia <[email protected]>

From: #7941 Co-authored-by: Paul Kim <[email protected]>

* launchpad: backport 7970 * cherry pick 7628 * fix tests * Update CHANGELOG.md * revert tiny portion of #7970 (#7984) Testable examples were accidentally converted into tests. * adapt test to launchpad * fix golangci-lint warnings Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: Alessio Treglia <[email protected]>

lgtm-com · 2020-11-20T11:30:10Z

This pull request fixes 1 alert when merging 5be42d9 into 6a624c3 - view on LGTM.com

fixed alerts:

1 for Incorrect conversion between integer types

alexanderbez · 2020-11-20T14:05:42Z

.github/CODEOWNERS

@@ -1,13 +1,5 @@
 # CODEOWNERS: https://help.github.com/articles/about-codeowners/

-# Primary repo maintainers


Any particular reason for these changes?

Changes committed as per Launchpad's release policy. The Policy states that PRs to the stable release branch must be approved by the Stable Release Managers.
Changes were approved offline by @okwme.

Ok this is just for launchpad?

Also, why is the base branch launchpad/release/v0.39.2? It should be release/v0.39.x or something similar.

Ok this is just for launchpad?

Currently yes, correct - although IIRC people liked the concept of having a small dedicated group of people maintaining each stable release branch. Yet yes of course, this applies to Launchpad only.

Also, why is the base branch launchpad/release/v0.39.2?

There should be ACLs enforced on branches that start with launchpad/

Anyways, the release branch will be removed once the final tag is pushed

I'm not sure I understand but ok!

…8001) types/Coin: compile and reuse Regexps to reduce massive RAM+CPU burn (#7989) From: #7989 Closes: #7986 Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Emmanuel T Odeke <[email protected]>

lgtm-com · 2020-11-24T06:29:02Z

This pull request fixes 1 alert when merging 2727c14 into 6a624c3 - view on LGTM.com

fixed alerts:

1 for Incorrect conversion between integer types

alessio · 2020-11-24T09:58:44Z

We're ready for liftoff:

Tests are green
Client testing successful, no regressions were reported.
All Stable Release Managers have signed off.

Hence tagging (git tag -a) and closing.

Thank you all very much indeed for making Cosmos SDK better.

Alessio Treglia and others added 16 commits August 18, 2020 17:20

fix tests build failures with go1.15 (#7073)

c7d0b5a

unblock CI on Launchpad (#7088)

86f953b

Replace old actions that don't build anymore.

launchpad: backport BigInt fix (#7087)

4d3afea

Backported from #7084 Co-authored-by: Alessio Treglia <[email protected]>

Update CODEWNERS as per Launchpad Release Policy (#7137)

42c3c57

client: fix keys add interactive command (#7193)

298fbbc

Fix the command line `keys add` interactive mode that fails when asked to generate new mnemonic. Closes: #7048 From: - #7049 - #7183 Thanks: @puneet2019 @PaddyMc for the patches.

Update 99designs/keyring to v1.1.6 for go 1.15 (#7398)

a1d18a1

The release contains a fix for dvsekhvalnov/jose2go#26, which is needed for the file keyring backend to work with go 1.15. From: #7397

Update launchpad docs to build without failing (#7412)

203876e

Update vuepress/config & package.json to match master. Touch package-lock.json.

make coin evaluation into functions instead of static

c3cc14c

reset default regex

5b6cff4

Update CHANGELOG.md

726d57a

Update CHANGELOG.md

a74a519

Merge branch 'launchpad/backports' into billy/6744-launchpad-custom-v…

85d4291

…alidation

Merge pull request #7450 from cosmos/billy/6744-launchpad-custom-vali…

3101928

…dation support denoms custom validation

tendermint security update (#7555)

59c6527

Update tendermint to 0.33.8, see [1] for more information. [1] golang/go#40618

post-upgrade with x/upgrade queries not working (#7531)

792c7bc

Origin: #7415 Closes: #7385 Thanks: @RiccardoM for the backport.

launchpad: fix query params on governance votes querier (#7624)

c4f4d03

From: #7589 Closes: #7588 Thanks: @YunSuk-Yeo Co-authored-by: Alessio Treglia <[email protected]>

alessio requested review from clevinson and ethanfrey October 23, 2020 11:05

ethanfrey approved these changes Oct 25, 2020

View reviewed changes

yun-yeo mentioned this pull request Oct 29, 2020

Master branch update to support Columbus-4 terra-money/classic-core#422

Merged

8 tasks

Alessio Treglia added 2 commits November 10, 2020 19:06

enrich version --long's output with build deps (#7864)

5cb54ab

The output of the version --long command now shows the list of build dependencies. From: #7848 Closes: #7835

update RELEASE_NOTES.md (#7858)

1bbffff

Closes: #7894

alessio marked this pull request as ready for review November 13, 2020 19:06

alessio requested review from alexanderbez and fedekunze as code owners November 13, 2020 19:06

alessio commented Nov 13, 2020

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

lovincyrus and others added 2 commits November 17, 2020 05:40

docs: fix broken urls (#7833)

2d38dad

Update CHANGELOG.md

0c2e3fa

Co-authored-by: Alessio Treglia <[email protected]>

Merge PR #7969: bump version git diff

7b152b3

fedekunze and others added 2 commits November 18, 2020 20:18

launchpad: bump tendermint to v0.33.9 (#7971)

36ff5ca

* launchpad: bump tendermint to v0.33.9 * update release notes Co-authored-by: Alessio Treglia <[email protected]>

version --long displays replaced build dependencies (#7943)

69f6ec2

From: #7941 Co-authored-by: Paul Kim <[email protected]>

This was referenced Nov 19, 2020

update to cosmos-sdk v0.39.2-rc2 iov-one/iovns#379

Closed

upgrade to cosmos-sdk v0.39.2 RC2 commercionetwork/commercionetwork#178

Merged

alessio changed the title ~~Launchpad/backports~~ Release v0.39.2 Nov 19, 2020

This was referenced Nov 20, 2020

update to cosmos-sdk v0.39.2 cosmos/ethermint#608

Merged

update to Cosmos SDK v0.39.2-rc3 iov-one/iovns#380

Closed

alexanderbez reviewed Nov 20, 2020

View reviewed changes

fedekunze approved these changes Nov 20, 2020

View reviewed changes

clevinson approved these changes Nov 23, 2020

View reviewed changes

alessio closed this Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.39.2 #7574

Release v0.39.2 #7574

alessio commented Oct 16, 2020 •

edited

Loading

yun-yeo commented Oct 21, 2020

alessio commented Oct 21, 2020

yun-yeo commented Oct 22, 2020

ethanfrey left a comment

alessio commented Nov 13, 2020

alessio commented Nov 16, 2020

tac0turtle commented Nov 18, 2020

fedekunze commented Nov 18, 2020

alessio commented Nov 18, 2020

lgtm-com bot commented Nov 20, 2020

alexanderbez Nov 20, 2020

alessio Nov 20, 2020

alexanderbez Nov 20, 2020

alessio Nov 20, 2020

alessio Nov 20, 2020

alexanderbez Nov 20, 2020

lgtm-com bot commented Nov 24, 2020

alessio commented Nov 24, 2020

		@@ -1,13 +1,5 @@
		# CODEOWNERS: https://help.github.com/articles/about-codeowners/

		# Primary repo maintainers

Release v0.39.2 #7574

Release v0.39.2 #7574

Conversation

alessio commented Oct 16, 2020 • edited Loading

yun-yeo commented Oct 21, 2020

alessio commented Oct 21, 2020

yun-yeo commented Oct 22, 2020

ethanfrey left a comment

Choose a reason for hiding this comment

alessio commented Nov 13, 2020

alessio commented Nov 16, 2020

tac0turtle commented Nov 18, 2020

fedekunze commented Nov 18, 2020

alessio commented Nov 18, 2020

lgtm-com bot commented Nov 20, 2020

alexanderbez Nov 20, 2020

Choose a reason for hiding this comment

alessio Nov 20, 2020

Choose a reason for hiding this comment

alexanderbez Nov 20, 2020

Choose a reason for hiding this comment

alessio Nov 20, 2020

Choose a reason for hiding this comment

alessio Nov 20, 2020

Choose a reason for hiding this comment

alexanderbez Nov 20, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Nov 24, 2020

alessio commented Nov 24, 2020

alessio commented Oct 16, 2020 •

edited

Loading