makefile: change build-docs target for shells other than bash #7444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/setup-go](https://github.com/actions/setup-go) from v2.1.2 to v2.1.3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2.1.2...37335c7) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ibc: protobuf v1 * update codec * core client * core connection * core host * core commitment * core port * core channel * core ibc module files * core exported * core types & simulation * core spec * make proto-all * ibc alias
* LGTM alerts audit * Update x/simulation/mock_tendermint.go Co-authored-by: Alessio Treglia <[email protected]> * Update x/staking/keeper/delegation.go Co-authored-by: Alessio Treglia <[email protected]> * comment false positive Co-authored-by: Alessio Treglia <[email protected]>
* update channel handshake Add ProvedID to ChanOpenTry which allows for flexible handshake identifier selection. Add CounterpartyChannelID to OpenAck. Update and add to handshake tests. Modify msgs_test. Counterparty ValidateBasic will return nil on an empty channel identifier to allow for flexible handshake identifier selection to succeed. * Update x/ibc/core/04-channel/keeper/handshake.go * add conn open init docs * update docs for conn open try and conn open ack * update channel docs
helder-moreira
requested review from
aaronc,
alessio and
alexanderbez
as code owners
9 tasks
|
This pull request fixes 5 alerts when merging f2ac04d into 136ca99 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
build-docstarget in Makefile to support shells other thanbash.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes