Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc: core restructure #7434

Merged
merged 16 commits into from
Oct 2, 2020
Merged

ibc: core restructure #7434

merged 16 commits into from
Oct 2, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Oct 1, 2020

Description

closes: #6945

tree -L 3 x/ibc/
x/ibc/
├── applications
│   └── transfer
│       ├── client
│       ├── handler.go
│       ├── handler_test.go
│       ├── keeper
│       ├── module.go
│       ├── module_test.go
│       ├── simulation
│       ├── spec
│       └── types
├── core
│   ├── 02-client
│   │   ├── abci.go
│   │   ├── abci_test.go
│   │   ├── client
│   │   ├── doc.go
│   │   ├── genesis.go
│   │   ├── handler.go
│   │   ├── handler_test.go
│   │   ├── keeper
│   │   ├── module.go
│   │   ├── simulation
│   │   └── types
│   ├── 03-connection
│   │   ├── client
│   │   ├── genesis.go
│   │   ├── handler.go
│   │   ├── keeper
│   │   ├── module.go
│   │   ├── simulation
│   │   └── types
│   ├── 04-channel
│   │   ├── client
│   │   ├── genesis.go
│   │   ├── handler.go
│   │   ├── keeper
│   │   ├── module.go
│   │   ├── simulation
│   │   └── types
│   ├── 05-port
│   │   ├── keeper
│   │   └── types
│   ├── 23-commitment
│   │   └── types
│   ├── 24-host
│   │   ├── errors.go
│   │   ├── keys.go
│   │   ├── parse.go
│   │   ├── validate.go
│   │   └── validate_test.go
│   ├── client
│   │   ├── cli
│   │   └── query.go
│   ├── exported
│   │   ├── channel.go
│   │   ├── client.go
│   │   ├── commitment.go
│   │   └── connection.go
│   ├── genesis.go
│   ├── genesis_test.go
│   ├── handler.go
│   ├── handler_test.go
│   ├── ibc_test.go
│   ├── keeper
│   │   ├── grpc_query.go
│   │   └── keeper.go
│   ├── module.go
│   ├── simulation
│   │   ├── decoder.go
│   │   ├── decoder_test.go
│   │   ├── genesis.go
│   │   └── genesis_test.go
│   ├── spec
│   │   ├── 01_concepts.md
│   │   ├── 02_state.md
│   │   ├── 03_state_transitions.md
│   │   ├── 04_messages.md
│   │   ├── 05_callbacks.md
│   │   ├── 06_events.md
│   │   └── README.md
│   └── types
│       ├── codec.go
│       ├── genesis.go
│       ├── genesis.pb.go
│       └── query.go
├── light-clients
│   ├── 06-solomachine
│   │   ├── client
│   │   ├── doc.go
│   │   ├── module.go
│   │   ├── spec
│   │   └── types
│   ├── 07-tendermint
│   │   ├── client
│   │   ├── doc.go
│   │   ├── module.go
│   │   └── types
│   └── 09-localhost
│       ├── doc.go
│       ├── module.go
│       └── types
└── testing
    ├── chain.go
    ├── coordinator.go
    ├── mock
    │   ├── README.md
    │   ├── doc.go
    │   ├── mock.go
    │   ├── privval.go
    │   └── privval_test.go
    ├── solomachine.go
    └── types.go

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@fedekunze fedekunze added S:blocked Status: Blocked x/ibc labels Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #7434 into master will increase coverage by 0.28%.
The diff coverage is 77.96%.

@@            Coverage Diff             @@
##           master    #7434      +/-   ##
==========================================
+ Coverage   54.81%   55.10%   +0.28%     
==========================================
  Files         587      588       +1     
  Lines       36512    36787     +275     
==========================================
+ Hits        20014    20270     +256     
- Misses      14406    14416      +10     
- Partials     2092     2101       +9     

Base automatically changed from fedekunze/7338-proto-ibc-v1 to master October 1, 2020 19:23
@fedekunze fedekunze marked this pull request as ready for review October 1, 2020 22:15
@fedekunze fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. and removed S:blocked Status: Blocked labels Oct 1, 2020
@cwgoes
Copy link
Contributor

cwgoes commented Oct 1, 2020

(needs a rebase)

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for doing this @fedekunze !!

@colin-axner colin-axner added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 2, 2020
@fedekunze fedekunze merged commit 2c93ec7 into master Oct 2, 2020
@fedekunze fedekunze deleted the fedekunze/6945-ibc-core branch October 2, 2020 09:03
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* ibc: protobuf v1

* update codec

* core client

* core connection

* core host

* core commitment

* core port

* core channel

* core ibc module files

* core exported

* core types & simulation

* core spec

* make proto-all

* ibc alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure x/ibc layout
3 participants