Final IBC migration and Amino removal #7157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
aaronc,
alessio and
alexanderbez
as code owners
colin-axner
commented
Aug 25, 2020
| @@ -103,7 +101,6 @@ message Evidence { | |||
| message Header { | |||
| .tendermint.types.SignedHeader signed_header = 1 [ | |||
| (gogoproto.embed) = true, | |||
| (gogoproto.nullable) = false, | |||
There was a problem hiding this comment.
I realize looking at the diffs that maybe making the signed header a pointer isn't necessary. Thoughts? Should I switch back?
There was a problem hiding this comment.
if we use a pointer we should add test cases to check for nil
| evidenceexported "github.com/cosmos/cosmos-sdk/x/evidence/exported" | ||
| clientexported "github.com/cosmos/cosmos-sdk/x/ibc/02-client/exported" | ||
| ) | ||
|
|
||
| // RegisterCodec registers the necessary x/ibc/07-tendermint interfaces and conrete types | ||
| // on the provided Amino codec. These types are used for Amino JSON serialization. | ||
| func RegisterCodec(cdc *codec.LegacyAmino) { |
| "github.com/cosmos/cosmos-sdk/x/ibc/keeper" | ||
| ) | ||
|
|
||
| type KeeperTestSuite struct { |
There was a problem hiding this comment.
there is no tests in this directory so I thought might as well delete this file
Codecov Report
@@ Coverage Diff @@
## master #7157 +/- ##
==========================================
- Coverage 55.60% 54.82% -0.78%
==========================================
Files 457 561 +104
Lines 27440 38327 +10887
==========================================
+ Hits 15257 21012 +5755
- Misses 11083 15604 +4521
- Partials 1100 1711 +611 |
fedekunze
approved these changes
Aug 25, 2020
|
I will start working on #7155, and I need this to work on the migration. Is it ok if we merge it and address the remaining reviews on a follow-up PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates TM messages to proto, changes evidence and headers to pointers, removes amino in all places except the client (cli and utils). Cli and utils are non-trivial to remove because I'm not sure how parsing ABCI queries works with proto. Trying to change it now would be untested and just a temporary fix to remove amino entirely. I think it is fine to just add this issue to the cli refactor issue. I think the amino reference issue can be closed though.
closes: #6566
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes