Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Amino in IBC verification #6566

Closed
cwgoes opened this issue Jul 1, 2020 · 2 comments · Fixed by #7157
Closed

Remove all references to Amino in IBC verification #6566

cwgoes opened this issue Jul 1, 2020 · 2 comments · Fixed by #7157
Assignees
Labels
S:blocked Status: Blocked

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jul 1, 2020

We should not use Amino to serialise or deserialise anything which is verified with proofs in IBC (so really anything at all).

@colin-axner
Copy link
Contributor

colin-axner commented Aug 3, 2020

to do's

  • migrate 23-commitments to proto (define Any for each interface)
  • migrate localhost client state to proto [migrate localhost client state to proto #6925]
  • migrate tendermint to use concrete commitment types instead of exported
  • migrate client messages to proto
  • migrate consensus states to proto
  • migrate headers/evidence to proto (requires tm update)
  • migrate client state to proto
  • remove amino registration in commitments post genesis
  • remove amino all amino registration after headers/evidence
  • all client/ funcs should use proto codec not LegacyAmino

@colin-axner colin-axner added the S:blocked Status: Blocked label Aug 7, 2020
@colin-axner
Copy link
Contributor

we can't do any more removal until

  • tendermint is updated (along with headers and evidence)
  • simapp is updated to supporting proto usage only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:blocked Status: Blocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants