Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove parts of amino from ibc #6819

Merged
merged 11 commits into from
Aug 3, 2020
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 22, 2020

Description

removes amino entirely from:

  • connections
  • channels
  • ibc-transfer

the rest of the amino references are non-trivial to remove and will be done in followup prs

ref: #6566


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #6819 into master will increase coverage by 5.97%.
The diff coverage is 55.73%.

@@            Coverage Diff             @@
##           master    #6819      +/-   ##
==========================================
+ Coverage   55.60%   61.57%   +5.97%     
==========================================
  Files         457      518      +61     
  Lines       27440    32003    +4563     
==========================================
+ Hits        15257    19707    +4450     
+ Misses      11083    10719     -364     
- Partials     1100     1577     +477     

@colin-axner colin-axner marked this pull request as ready for review August 3, 2020 11:22
@colin-axner colin-axner changed the title remove amino from ibc remove parts of amino from ibc Aug 3, 2020
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 3, 2020
@fedekunze fedekunze merged commit 00961f2 into master Aug 3, 2020
@fedekunze fedekunze deleted the colin/remove-amino-from-ibc branch August 3, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Encoding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants