Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Binary & Command Refactor #6595

Merged
merged 52 commits into from
Jul 7, 2020
Merged

Single Binary & Command Refactor #6595

merged 52 commits into from
Jul 7, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 3, 2020 •
edited
Loading

  • Merge CLI and Daemon binaries into one (credit: @dauTT!!!)
  • Refactor commands
  • No longer pass server Context and Codecs by arguments

closes: #6419

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

dauTT and others added 30 commits June 28, 2020 23:40
@dauTT
Merge simcli into simd
4a1fb27
@dauTT
Get rid of the unused variable config
26aea15
@dauTT
Rename SimcliBinary to SimdBinary
b7fee05
@dauTT
Resolve flag -o shorthand ambiguity. (It is used both to indicate <ou…
84ef4c6 
…tput string> and <overwrite>)
@dauTT
Resolve flags conflict with genTx cmd in x/genutil/client/cli/gentx.go
103e884
@alexanderbez
Merge branch 'master' into single-binary-6419
27fdd02
Merge branch 'master' into single-binary-6419
8859370
@dauTT
Move ./simapp/cmd/simd to ./cmd/simd
fd964da
@alexanderbez
Merge branch 'master' into single-binary-6419
fccd048
@dauTT
Sort available commands
01da4cf
@dauTT
Simplify code
7a84bcb
@dauTT
Uncomment line. Issue got reolved automatically. :)
4bc67f4
@dauTT
Merge branch 'single-binary-6419' of https://github.com/dauTT/cosmos-sdk
66eba9d 
 into single-binary-6419
@dauTT
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into si…
17e9e5f 
…ngle-binary-6419
@dauTT
Adjust version module to use only one binary and refactor accordingly
24fc533
@dauTT
1) Remove global variables
3b346ae 
2) Fix integration test issue related to the gentx command which was not working properly due to using gloabal variables
@dauTT
Fix lint error message (Remove unused flags: fsShares, fsValidator, f…
e80e1b3 
…sRedelegation)

Update Dockerfile
@dauTT
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into si…
39e34e5 
…ngle-binary-6419
@dauTT
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into si…
0f99749 
…ngle-binary-6419
@dauTT
Delete TODO during the merge. Added it back
2b58e8d
@tac0turtle
Merge branch 'master' into single-binary-6419
171064c
@alexanderbez
Merge branch 'master' into single-binary-6419
e64e4f8
@alexanderbez @fedekunze
Apply suggestions from code review
052db8c 
Co-authored-by: Federico Kunze <[email protected]>
@dauTT
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into si…
c862dbf 
…ngle-binary-6419
@dauTT
Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into si…
160a0ae 
…ngle-binary-6419
Merge branch 'master' into single-binary-6419
9242385
Merge branch 'master' into single-binary-6419
e49d18a
@alexanderbez
Merge branch 'master' into single-binary-6419
80de6d9
@alexanderbez
Init commit
bc30fd2
@alexanderbez
remove viper start
73f22f5
@alexanderbez alexanderbez changed the title Single Binary Single Binary & Command Refactor Jul 7, 2020
@alexanderbez alexanderbez marked this pull request as ready for review July 7, 2020 15:04
@alexanderbez alexanderbez added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). C:CLI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T: Dev UX UX for SDK developers (i.e. how to call our code) labels Jul 7, 2020
tac0turtle
tac0turtle reviewed Jul 7, 2020
View reviewed changes
Makefile Show resolved Hide resolved
fedekunze
fedekunze approved these changes Jul 7, 2020
View reviewed changes
server/util.go Show resolved Hide resolved
simapp/simd/cmd/genaccounts.go Show resolved Hide resolved
simapp/simd/cmd/root.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 8670a10 into master Jul 7, 2020
@alexanderbez alexanderbez deleted the bez/6419-attempt-fix branch July 7, 2020 15:40
@fedekunze fedekunze mentioned this pull request Aug 5, 2020
Closed
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@alexanderbez
Merge PR cosmos#6595: Single Binary & Command Refactor
a9f7dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@clevinson clevinson Awaiting requested review from clevinson

@jgimeno jgimeno Awaiting requested review from jgimeno

@atheeshp atheeshp Awaiting requested review from atheeshp

@sahith-narahari sahith-narahari Awaiting requested review from sahith-narahari

@anilcse anilcse Awaiting requested review from anilcse

Assignees

@jgimeno jgimeno

@alexanderbez alexanderbez

Labels
C:CLI T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: Dev UX UX for SDK developers (i.e. how to call our code) Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single CLI binary
5 participants
@alexanderbez @dauTT @tac0turtle @fedekunze @jgimeno