Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single CLI binary #6419

Closed
1 of 4 tasks
aaronc opened this issue Jun 12, 2020 · 8 comments · Fixed by #6595
Closed
1 of 4 tasks

Single CLI binary #6419

aaronc opened this issue Jun 12, 2020 · 8 comments · Fixed by #6595

Comments

@aaronc
Copy link
Member

aaronc commented Jun 12, 2020

Summary

ref: #6408

A single binary with be lighter weight and more convenient than two binaries xxxxd and xxxxcli.

Problem Definition

simd and simcli, etc. have mostly the same code but different cmd's. Currently 42mb for simcli and 50mb for simd.

Proposal

Just have a single cmd that will be lighter weight and pack everything needed.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@aaronc aaronc added this to the v0.40 milestone Jun 12, 2020
@tac0turtle
Copy link
Member

tac0turtle commented Jun 19, 2020

does this need any design work? If someone in the community were to pick it up prior to 0.39 release would it be included?

@alexanderbez
Copy link
Contributor

@marbar3778 not really, and yes please! It should be more or less trivial. Move command instantiation around and remove *cli remainings.

@dauTT
Copy link
Contributor

dauTT commented Jun 25, 2020

Hi, can I work on this?

@anilcse
Copy link
Collaborator

anilcse commented Jun 25, 2020

Hi, can I work on this?

That would be a great help, 🙏

@alexanderbez
Copy link
Contributor

@dauTT yes pls 🙏 let us know if you need guidance on this, but I think it should be pretty straight forward.

@dauTT
Copy link
Contributor

dauTT commented Jun 25, 2020

Is it okay if I follow this convention?

  1. single binary name: sim
  2. sim client = simcli
  3. sim daemon = simd

Selection_079
Selection_080

@aaronc
Copy link
Member Author

aaronc commented Jun 25, 2020

@dauTT let's just have all the commands at the top level. So the user would type sim start, sim query, etc.

As for the naming of the binary, I think sim is fine although maybe we choose to adopt one of simd or simcli.

Thanks for looking into this!

@dauTT dauTT mentioned this issue Jun 28, 2020
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants