x/ibc: simulation store decoders #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5935-ibc-decoders
…s-sdk into fedekunze/5935-ibc-decoders
Codecov Report
@@ Coverage Diff @@
## master #6247 +/- ##
==========================================
+ Coverage 55.60% 55.69% +0.09%
==========================================
Files 457 464 +7
Lines 27444 27519 +75
==========================================
+ Hits 15259 15328 +69
- Misses 11084 11090 +6
Partials 1101 1101 |
fedekunze
requested review from
aaronc,
alessio,
alexanderbez,
clevinson and
jgimeno
as code owners
AdityaSripal
approved these changes
Jun 9, 2020
|
|
||
| kvPairs := tmkv.Pairs{ | ||
| tmkv.Pair{ | ||
| Key: append(host.KeyClientStorePrefix, append([]byte("/"+clientID+"/"), host.KeyClientState()...)...), |
There was a problem hiding this comment.
nit: Can these appends be in a helper function?
…s-sdk into fedekunze/5935-ibc-decoders
fedekunze
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5935
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer