Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] IBC module and required refactoring #565

Closed
wants to merge 31 commits into from
Closed

[WIP] IBC module and required refactoring #565

wants to merge 31 commits into from

Conversation

denalimarsh
Copy link
Contributor

Adding the IBC module is straightforward, with only a few additions in app.go. But in order to use the cosmos-sdk version that includes IBC, extensive refactoring is required. The app compiles, but more changes are needed in order to start the chain.

General

  • AppModule and AppModuleBasic changed and needed to be updated for each module.
  • acc.GetCoins() is now bankKeeper.SpendableCoins(). Module accounts are now in auth Move ModuleAccount to x/auth cosmos/cosmos-sdk#6029. Most modules' expected keepers had to be updated.

Committee

Validator Vesting

Simulations (commented out in b62e86b)

Cosmos SDK Version

  • this branch uses github.com/cosmos/cosmos-sdk v0.34.4-0.20200528144628-f8bad078b7b3, which was the most up-to-date version when I started the refactor.
  • gaia@master is now using github.com/cosmos/cosmos-sdk v0.34.4-0.20200511222341-80be50319ca5.

@denalimarsh denalimarsh added the WIP PR is a work in progress and not ready for review label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR is a work in progress and not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants