Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.37.1 RC1 Cherry Picks #5054

Merged
merged 9 commits into from
Sep 19, 2019
Merged

v0.37.1 RC1 Cherry Picks #5054

merged 9 commits into from
Sep 19, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 17, 2019

Cherry-pick PRs/commits from master:

/cc @tnachen @jackzampolin


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez changed the base branch from master to rc1/v0.37.1 September 17, 2019 13:40
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #5054 into rc1/v0.37.1 will decrease coverage by 0.07%.
The diff coverage is 20.27%.

@@               Coverage Diff               @@
##           rc1/v0.37.1    #5054      +/-   ##
===============================================
- Coverage        51.05%   50.97%   -0.08%     
===============================================
  Files              290      290              
  Lines            18801    18850      +49     
===============================================
+ Hits              9599     9609      +10     
- Misses            8509     8548      +39     
  Partials           693      693

@mircea-c
Copy link

Start sim

@alexanderbez alexanderbez merged commit da6e9ad into rc1/v0.37.1 Sep 19, 2019
@alexanderbez alexanderbez deleted the cherry-picks/rc1/v0.37.1 branch September 19, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants