Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile runsim targets #5015

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 9, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #5015 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5015      +/-   ##
==========================================
- Coverage   55.57%   55.56%   -0.02%     
==========================================
  Files         287      287              
  Lines       17521    17521              
==========================================
- Hits         9737     9735       -2     
- Misses       7083     7085       +2     
  Partials      701      701

@alexanderbez alexanderbez merged commit 2c4faf9 into master Sep 9, 2019
@alexanderbez alexanderbez deleted the bez/fix-makefile-runsim branch September 9, 2019 13:54
@alexanderbez alexanderbez mentioned this pull request Sep 17, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants