-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gaiad: ExportGenesisFile() incorrectly overwrites genesis #4063
Merged
alessio
merged 5 commits into
develop
from
alessio/3130-dont-reset-tendermint-genesis-params-on-collect
Apr 8, 2019
Merged
gaiad: ExportGenesisFile() incorrectly overwrites genesis #4063
alessio
merged 5 commits into
develop
from
alessio/3130-dont-reset-tendermint-genesis-params-on-collect
Apr 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4063 +/- ##
===========================================
- Coverage 60.01% 59.95% -0.06%
===========================================
Files 212 212
Lines 15107 15108 +1
===========================================
- Hits 9066 9058 -8
- Misses 5420 5428 +8
- Partials 621 622 +1 |
alessio
force-pushed
the
alessio/3130-dont-reset-tendermint-genesis-params-on-collect
branch
from
April 6, 2019 13:17
6b4bd28
to
0343fc3
Compare
alessio
force-pushed
the
alessio/3130-dont-reset-tendermint-genesis-params-on-collect
branch
from
April 6, 2019 18:09
0343fc3
to
2f0b833
Compare
5 tasks
fedekunze
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
alexanderbez
approved these changes
Apr 8, 2019
jaekwon
reviewed
Apr 8, 2019
alessio
deleted the
alessio/3130-dont-reset-tendermint-genesis-params-on-collect
branch
April 8, 2019 17:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportGenesisFile() overwrites all non-gaia related
sections of the genesis.json file as it always
creates a new one from scratch.
Remove cmd/gaia/init.LoadGenesisDoc() in favor of
tendermint's types.GenesisDocFromFile().
Closes: #4066
docs/
)sdkch add [section] [stanza] [message]
Files changed
in the github PR explorerFor Admin Use: