Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LoadGenesisDoc() in favor of GenesisDocFromFile() #4062

Closed
wants to merge 2 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 5, 2019

Duplication of effort discovered while on #3130

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio marked this pull request as ready for review April 5, 2019 18:58
@alessio
Copy link
Contributor Author

alessio commented Apr 5, 2019

This should be listed as an improvement rather than a breaking change as it affects a gaia internal API. No SDK users should depend on gaia internal APIs

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@055d219). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             develop    #4062   +/-   ##
==========================================
  Coverage           ?   59.76%           
==========================================
  Files              ?      212           
  Lines              ?    15151           
  Branches           ?        0           
==========================================
  Hits               ?     9055           
  Misses             ?     5452           
  Partials           ?      644

@alessio alessio closed this Apr 6, 2019
@alessio alessio deleted the 3130-remove-load-genesis-doc branch April 6, 2019 12:30
@alessio
Copy link
Contributor Author

alessio commented Apr 6, 2019

Superseded by #4063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant