-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coin #312
Merged
+319
−320
Merged
Coin #312
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c441927
wip: tests and fixes for kvstore iteration
ebuchman 4e2adc0
update for latest tmlibs
ebuchman e4a179b
types compiles
ebuchman 32a814a
x/coin almost compiles
ebuchman 14994fc
x/coin: move things out of the way so it builds
ebuchman 2df33bb
rebase fixes
ebuchman 29bb2cc
update glide
ebuchman 3d14fd3
add test for ChainDecorators
ebuchman d4cd1f0
wip
jaekwon 5d8d20f
Update handler.go
jaekwon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package types | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/cosmos/cosmos-sdk/store" | ||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestDecorate(t *testing.T) { | ||
|
||
var calledDec1, calledDec2, calledHandler bool | ||
dec1 := func(ctx Context, ms store.MultiStore, tx Tx, next Handler) Result { | ||
calledDec1 = true | ||
next(ctx, ms, tx) | ||
return Result{} | ||
} | ||
|
||
dec2 := func(ctx Context, ms store.MultiStore, tx Tx, next Handler) Result { | ||
calledDec2 = true | ||
next(ctx, ms, tx) | ||
return Result{} | ||
} | ||
|
||
handler := func(ctx Context, ms store.MultiStore, tx Tx) Result { | ||
calledHandler = true | ||
return Result{} | ||
} | ||
|
||
decoratedHandler := ChainDecorators(dec1, dec2).WithHandler(handler) | ||
|
||
var ctx Context | ||
var ms store.MultiStore | ||
var tx Tx | ||
decoratedHandler(ctx, ms, tx) | ||
assert.True(t, calledDec1) | ||
assert.True(t, calledDec2) | ||
assert.True(t, calledHandler) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
package types | ||
|
||
import ( | ||
"github.com/cosmos/cosmos-sdk" | ||
sdk "github.com/cosmos/cosmos-sdk" | ||
) | ||
|
||
// Handler handles both ABCI DeliverTx and CheckTx requests. | ||
// Iff ABCI.CheckTx, ctx.IsCheckTx() returns true. | ||
type Handler func(ctx Context, ms MultiStore, tx Tx) | ||
type Handler func(ctx Context, ms sdk.MultiStore, tx Tx) Result |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL. Blame protobuf. I don't know if we can force the name change, maybe gogo lets us do that too ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh haha you did it! #hero