Coin #312
Merged
Coin #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
commented
Dec 21, 2017
types/context.go
Outdated
| @@ -18,7 +18,7 @@ func NewContext(header abci.Header, isCheckTx bool, txBytes []byte) Context { | |||
| } | |||
| c = c.setBlockHeader(header) | |||
| c = c.setBlockHeight(header.Height) | |||
| c = c.setChainID(header.ChainId) | |||
| c = c.setChainID(header.ChainID) | |||
There was a problem hiding this comment.
LOL. Blame protobuf. I don't know if we can force the name change, maybe gogo lets us do that too ...
There was a problem hiding this comment.
Oh haha you did it! #hero
jaekwon
pushed a commit
that referenced
this pull request
Dec 21, 2017
jaekwon
pushed a commit
that referenced
this pull request
Dec 21, 2017
faddat
referenced
this pull request
in notional-labs/cosmos-sdk
Aug 21, 2022
…312) * added new constructor for genesis supply that matches upstream * moved to decorator pattern
rootulp
referenced
this pull request
in rootulp/cosmos-sdk
May 17, 2023
chore: upgrade to celestia-core v1.18.0-tm-v0.34.27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup to get things to build.