-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Remove AppInit #2801
R4R: Remove AppInit #2801
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2801 +/- ##
========================================
Coverage 56.73% 56.73%
========================================
Files 131 131
Lines 8554 8554
========================================
Hits 4853 4853
Misses 3368 3368
Partials 333 333 |
@@ -98,11 +98,6 @@ The `simplegovd` command will run the daemon server as a background process. Fir | |||
|
|||
```go | |||
// cmd/simplegovd/main.go | |||
// SimpleGovAppInit initial parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small note here, I think this is getting moved in the docs update. I have a feeling that is going to merge first, so this will be a merge conflict.
Looks good and doesn't break anything when I run locally. Can you provide a bit more info on why this change was made and if there are any user facing side effects? |
@jackzampolin Code cleanup, AppInit is no longer required. Updated description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah changes LGTM mostly. Can you resolve the doc merge conflicts? Then should be g2g.
ec8ef6c
to
005f1b8
Compare
005f1b8
to
8ba7689
Compare
Picking #2675 up from where @jaekwon left it.
Code cleanup, AppInit is no longer required.
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: