Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Remove AppInit #2801

Merged
merged 2 commits into from
Nov 15, 2018
Merged

R4R: Remove AppInit #2801

merged 2 commits into from
Nov 15, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Nov 14, 2018

Picking #2675 up from where @jaekwon left it.

Code cleanup, AppInit is no longer required.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title Remove AppInit WIP: Remove AppInit Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2801 into develop will not change coverage.
The diff coverage is 50%.

@@           Coverage Diff            @@
##           develop    #2801   +/-   ##
========================================
  Coverage    56.73%   56.73%           
========================================
  Files          131      131           
  Lines         8554     8554           
========================================
  Hits          4853     4853           
  Misses        3368     3368           
  Partials       333      333

@alessio alessio changed the title WIP: Remove AppInit R4R: Remove AppInit Nov 14, 2018
@@ -98,11 +98,6 @@ The `simplegovd` command will run the daemon server as a background process. Fir

```go
// cmd/simplegovd/main.go
// SimpleGovAppInit initial parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small note here, I think this is getting moved in the docs update. I have a feeling that is going to merge first, so this will be a merge conflict.

@jackzampolin
Copy link
Member

Looks good and doesn't break anything when I run locally. Can you provide a bit more info on why this change was made and if there are any user facing side effects?

@alessio
Copy link
Contributor Author

alessio commented Nov 14, 2018

@jackzampolin Code cleanup, AppInit is no longer required. Updated description.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah changes LGTM mostly. Can you resolve the doc merge conflicts? Then should be g2g.

@jackzampolin jackzampolin merged commit 815a6de into develop Nov 15, 2018
@jackzampolin jackzampolin deleted the alessio/app-init-cleanup branch November 15, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants