Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.30 SDK #353

Merged
merged 2 commits into from
Feb 11, 2019
Merged

Upgrade to 0.30 SDK #353

merged 2 commits into from
Feb 11, 2019

Conversation

jhernandezb
Copy link
Contributor

@jhernandezb jhernandezb commented Feb 9, 2019

The upgrade changes are listed below and also fixes #335

Updates to dependencies

  • cosmos-sdk=v0.30
  • tendermint=v0.29.2
  • go-amino=0.14.1
  • tendermint/iavl=v0.12.0

Breaking/notable changes in cosmos

  • x/state renamed to x/staking see PR
  • sdk.CodespaceType is now string (usually the name of the module is used) see PR
  • StdSignature no longer serializes AccountNumber and SequenceNumber see PR
  • auth.Account: AccountNumber and SequenceNumber are now uint64
  • Rename MountStoresIAVL to MountStores see PR
  • Minimum fee should be configured in gaid.toml but now they introduced SetMinGasPrices which is not included in v0.30 so left a TODO comment to update in future versions if needed/required see PR
  • server.DefaultAppInit is removed see PR
  • Tendermint private validator file has changed format and file name but the app will handle this and update the file creating two new files priv_validator_key.json and priv_validator.json.bak both added to gitignore
  • CLI got some changes too
  • Moniker prop should be configured in config.toml or will panic at runtime since will fail new validations

Action required

Update the genesis file to include the following state in the app_state

  "app_state": {
    "auth": {
      "collected_fees": null,
      "params": {
        "MemoCostPerByte": "3",
        "MaxMemoCharacters": "256",
        "TxSigLimit": "7",
        "SigVerifyCostED25519": "590",
        "SigVerifyCostSecp256k1": "1000"
      }
    },
    "bank": {
      "send_enabled": true
    },
    // "accounts":  [...]
}

@shanev shanev merged commit 392abe2 into master Feb 11, 2019
@jhernandezb jhernandezb deleted the feature/sdk-v0.30-upgrade branch March 4, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants