refactor(server): alias AppOptions to coreserver.DynamicConfig

[julienrbrt]

Description

To limit breaking changes, I went with the alias way.
I have verified that depinject would still resolve it properly the alias in x/upgrade (https://github.com/cosmos/cosmos-sdk/blob/57f35dc/x/upgrade/depinject.go#L44) when providing AppOptions (

cosmos-sdk/simapp/app_di.go

Line 133 in 57f35dc

appOpts,

)

Closes: #21660

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features

  • Introduced GetString method for mapGetter to retrieve string values safely.
  • Added GetString method for AppOptionsMap to enhance type safety when accessing string values.
  • Added GetString method for AppOptionsFn to improve type safety in client code.

• Improvements

  • Streamlined AppOptions interface for better integration and maintainability by using server.DynamicConfig.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve refactoring the AppOptions interface in the server/types/app.go file to use server.DynamicConfig instead. Additionally, new methods GetString have been added to the mapGetter, AppOptionsMap, and AppOptionsFn types, allowing for type-safe retrieval of string values. These modifications streamline the codebase and enhance the usability of configuration management.

Changes

Files	Change Summary
server/types/app.go	Replaced AppOptions interface { Get(string) interface{} } with AppOptions = server.DynamicConfig.
server/util_test.go	Added func (m mapGetter) GetString(key string) string to retrieve string values from the underlying map.
testutil/sims/app_helpers.go	Added func (m AppOptionsMap) GetString(key string) string for type-safe retrieval of string values from the map.
testutils/sims/runner.go	Added func (f AppOptionsFn) GetString(k string) string to retrieve string values from the function.

Assessment against linked issues

Objective	Addressed	Explanation
Replace usages of server/types.AppOptions with core/server.DynamicConfig (#21660)	✅

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b146413 and a1b2d91.

Files selected for processing (1)

• testutils/sims/runner.go (1 hunks)

Additional context used

Path-based instructions (1)

testutils/sims/runner.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (1)

testutils/sims/runner.go (1)

238-240: LGTM!

The GetString method is a nice addition to the AppOptionsFn type. It provides a convenient and type-safe way to retrieve string values from the options function.

The implementation is straightforward and aligns with Go best practices:

• It is a small, focused function that does one thing well.
• It uses type assertion to ensure the returned value is a string, improving type safety.

Great job!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@julienrbrt your pull request is missing a changelog!