Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: replace usages of server/types.AppOptions with core/server.DynamicConfig #21660

Closed
kocubinski opened this issue Sep 11, 2024 · 0 comments · Fixed by #21711
Closed

[Refactor]: replace usages of server/types.AppOptions with core/server.DynamicConfig #21660

kocubinski opened this issue Sep 11, 2024 · 0 comments · Fixed by #21711
Assignees
@julienrbrt

Comments

@kocubinski
Copy link
Member

kocubinski commented Sep 11, 2024 •
edited
Loading

Following the merge of #21635, all usages of AppOptions should be replaced with core/server.DynamicConfig. If the interface needs modification, feel free to propose it. Reported usages from Goland below, which is usually mostly correct.

Image
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Sep 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Sep 11, 2024
@julienrbrt julienrbrt self-assigned this Sep 12, 2024
@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label Sep 12, 2024
@julienrbrt julienrbrt moved this from 📋 Backlog to 🤸‍♂️ In Progress in Cosmos-SDK Sep 12, 2024
@julienrbrt julienrbrt mentioned this issue Sep 13, 2024
Merged
12 tasks
@julienrbrt julienrbrt moved this from 🤸‍♂️ In Progress to 👀 Waiting / In review in Cosmos-SDK Sep 13, 2024
@github-project-automation github-project-automation bot moved this from 👀 Waiting / In review to 🥳 Done in Cosmos-SDK Sep 13, 2024
@mergify mergify bot mentioned this issue Sep 13, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
None yet
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(server): alias AppOptions to coreserver.DynamicConfig cosmos/cosmos-sdk
2 participants
@kocubinski @julienrbrt