R4R: Validator unbonding state #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigelrozanski
changed the title
rigelrozanski
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #2163 +/- ##
==========================================
Coverage ? 64.18%
==========================================
Files ? 140
Lines ? 8567
Branches ? 0
==========================================
Hits ? 5499
Misses ? 2692
Partials ? 376 |
melekes
reviewed
Aug 30, 2018
x/stake/types/validator.go
Outdated
| @@ -423,6 +418,19 @@ func (v Validator) BondedTokens() sdk.Dec { | |||
| return sdk.ZeroDec() | |||
| } | |||
|
|
|||
| // Returns if the validator should be considered unbonded | |||
| func (v Validator) IsUnbonded(ctx sdk.Context) bool { | |||
| if v.Status == sdk.Unbonded { | |||
There was a problem hiding this comment.
oh ic switch on the status. Okay yup ++
| @@ -134,12 +143,12 @@ func (k Keeper) Unjail(ctx sdk.Context, pubkey crypto.PubKey) { | |||
| } | |||
|
|
|||
| // set the jailed flag on a validator | |||
| func (k Keeper) setJailed(ctx sdk.Context, pubkey crypto.PubKey, jailed bool) { | |||
| func (k Keeper) setJailed(ctx sdk.Context, pubkey crypto.PubKey, isJailed bool) { | |||
There was a problem hiding this comment.
(out of curiosity) why did you decide to rename?
There was a problem hiding this comment.
When I first read this it confused me a bit, had to read it twice before it clicked - so I figured it'd probably confuse others at some point too. I think the word jailed might be overloaded just a tiny bit - I figured isJailed is just a little bit more explicit. Very minor though.
x/stake/types/validator.go
Outdated
| @@ -423,6 +418,19 @@ func (v Validator) BondedTokens() sdk.Dec { | |||
| return sdk.ZeroDec() | |||
| } | |||
|
|
|||
| // Returns if the validator should be considered unbonded | |||
| func (v Validator) IsUnbonded(ctx sdk.Context) bool { | |||
| if v.Status == sdk.Unbonded { | |||
alexanderbez
approved these changes
Aug 31, 2018
cwgoes
approved these changes
Aug 31, 2018
| @@ -45,6 +45,7 @@ func SupplyInvariants(ck bank.Keeper, k stake.Keeper, am auth.AccountMapper) sim | |||
| case sdk.Bonded: | |||
| bonded = bonded.Add(validator.GetPower()) | |||
| case sdk.Unbonding: | |||
| loose = loose.Add(validator.GetTokens().RoundInt()) | |||
There was a problem hiding this comment.
💯 for updating the invariants!
|
Making required updates now |
|
@cwgoes corrections for the new develop have been made |
This was referenced Sep 1, 2018
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1676
Closes #1877
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: