feat(x/genutil)!: bulk add genesis accounts #21372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe changes introduce a new command in the Cosmos SDK CLI to allow bulk addition of genesis accounts from a JSON file, significantly enhancing the process of initializing multiple accounts during network setup. This update includes modifications to several functions, the introduction of a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant GenUtil
participant JSONFile
User->>CLI: command bulk-add-genesis-account
CLI->>JSONFile: read JSON file
JSONFile-->>CLI: return account data
CLI->>GenUtil: AddGenesisAccounts(accounts)
GenUtil-->>CLI: process accounts and handle errors
CLI-->>User: return success/error message
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
julienrbrt
added
the
backport/v0.50.x
julienrbrt
reviewed
Aug 20, 2024
| // Where `cdc` is client codec, `genesisFileUrl` is the path/url of current genesis file, | ||
| // `accAddr` is the address to be added to the genesis state, `amountStr` is the list of initial coins | ||
| // to be added for the account, `appendAcct` updates the account if already exists. | ||
| // `vestingStart, vestingEnd and vestingAmtStr` respectively are the schedule start time, end time (unix epoch) | ||
| // `moduleName` is the module name for which the account is being created | ||
| // and coins to be appended to the account already in the genesis.json file. | ||
| func AddGenesisAccount( | ||
| func AddGenesisAccounts( |
There was a problem hiding this comment.
As it's api break in the 0.50 backport we will keep both around.
On main + 0.52 we can do this indeed.
julienrbrt
added
the
backport/v0.52.x
Reecepbcups
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
x/genutil/client/cli/genaccount_test.go (1)
237-257: Consider improving readability with comments.Adding comments to explain the logic behind the loop and error handling could improve readability.
// apply multiple state iterations if applicable (e.g. --append) for _, state := range tc.state { + // Marshal the state to JSON and write to a temporary file bz, err := json.Marshal(state) require.NoError(t, err) filePath := path.Join(home, "accounts.json") err = os.WriteFile(filePath, bz, 0o600) require.NoError(t, err) cmd := genutilcli.AddBulkGenesisAccountCmd() args := []string{filePath} if tc.appendFlag { args = append(args, "--append") } cmd.SetArgs(args) + // Execute the command and track if any errors occur err = cmd.ExecuteContext(ctx) if err != nil { doesErr = true } }
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (5)
- CHANGELOG.md (5 hunks)
- x/genutil/client/cli/commands.go (1 hunks)
- x/genutil/client/cli/genaccount.go (3 hunks)
- x/genutil/client/cli/genaccount_test.go (4 hunks)
- x/genutil/genaccounts.go (1 hunks)
Additional context used
Path-based instructions (5)
x/genutil/client/cli/commands.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/genutil/client/cli/genaccount.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/genutil/genaccounts.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/genutil/client/cli/genaccount_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Learnings (1)
x/genutil/client/cli/genaccount_test.go (1)
Learnt from: testinginprod PR: cosmos/cosmos-sdk#18542 File: x/bank/types/balance.go:64-77 Timestamp: 2023-11-22T14:48:50.376Z Learning: - The `SanitizeGenesisBalances` function in `x/bank/types/balance.go` of the Cosmos SDK should panic when encountering duplicate account addresses in the genesis state. - A test case is required to verify the behavior of `SanitizeGenesisBalances` when duplicates are present.
Additional comments not posted (12)
x/genutil/client/cli/commands.go (1)
44-44: Integration ofAddBulkGenesisAccountCmdis seamless.The new command for bulk addition of genesis accounts is well integrated into the existing command structure.
x/genutil/client/cli/genaccount_test.go (2)
Line range hint
29-119: LGTM! Test function is well-structured.The
TestAddGenesisAccountCmdfunction is well-structured and covers various scenarios effectively.
121-281: LGTM! Test function is comprehensive.The
TestBulkAddGenesisAccountCmdfunction is comprehensive and effectively covers various scenarios.CHANGELOG.md (5)
82-82: Entry for new CLI command looks good.The addition of the
bulk-add-genesis-accountcommand is clearly documented.
144-144: Documentation of client command changes is clear.The removal of the home directory requirement and deprecated functions is well-documented.
200-200: Documentation of function signature changes is clear.The changes to
HasAminoCodecand the deprecation ofServerContextare well-documented.
212-212: Documentation of client breaking changes is clear.The breaking change related to app config implementation is well-documented.
276-276: Documentation of improvements is clear.The improvements in telemetry and the introduction of the
Nowfunction are well-documented.x/genutil/client/cli/genaccount.go (2)
76-102: LGTM! But verify the function usage in the codebase.The changes to use
genutil.AddGenesisAccountsare consistent with the new bulk addition functionality.Ensure that all function calls to
AddGenesisAccountCmdare updated to reflect the new logic.Run the following script to verify the function usage:
Verification successful
Verification Successful: Function Usage Consistent
The
AddGenesisAccountCmdfunction is consistently used across the codebase, and the new logic is being tested ingenaccount_test.go. The transition to usinggenutil.AddGenesisAccountsappears to be correctly implemented.
- Files with usage:
x/genutil/v2/cli/commands.gox/genutil/client/cli/commands.gox/genutil/client/cli/genaccount_test.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `AddGenesisAccountCmd`. # Test: Search for the function usage. Expect: Only occurrences of the new logic. rg --type go -A 5 $'AddGenesisAccountCmd'Length of output: 2742
117-152: LGTM! Ensure robust error handling and verify the function usage.The new command for bulk addition is well-implemented with appropriate error handling for file operations and JSON decoding.
Ensure that the function is correctly integrated and used within the codebase.
Run the following script to verify the function usage:
Verification successful
Function
AddBulkGenesisAccountCmdis properly integrated and tested.The function is correctly used within the codebase, as confirmed by its presence in both test files and command integration.
- Integration: Found in
x/genutil/client/cli/commands.go, indicating it is part of the command set.- Testing: Found in
x/genutil/client/cli/genaccount_test.go, ensuring its functionality is verified.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `AddBulkGenesisAccountCmd`. # Test: Search for the function usage. Expect: Proper integration and usage. rg --type go -A 5 $'AddBulkGenesisAccountCmd'Length of output: 1572
x/genutil/genaccounts.go (2)
18-30: LGTM! TheGenesisAccountstruct is well-defined.The struct encapsulates the necessary properties for a genesis account, providing a clear and organized representation of account data.
32-156: LGTM! Ensure robust error handling and verify the function usage.The refactoring to handle multiple accounts is well-implemented, with appropriate error handling and performance enhancements.
Ensure that the function is correctly integrated and used within the codebase.
Run the following script to verify the function usage:
Verification successful
Function
AddGenesisAccountsis properly integrated and used.The function is correctly utilized within the CLI commands, ensuring its intended functionality is accessible through the command-line interface.
- File:
x/genutil/client/cli/genaccount.go
- Usage: The function is called twice, indicating its role in adding genesis accounts via CLI.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `AddGenesisAccounts`. # Test: Search for the function usage. Expect: Proper integration and usage. rg --type go -A 5 $'AddGenesisAccounts'Length of output: 1747
julienrbrt
reviewed
Aug 22, 2024
CHANGELOG.md
Outdated
| @@ -79,6 +79,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i | |||
| * (crypto/keyring) [#20212](https://github.com/cosmos/cosmos-sdk/pull/20212) Expose the db keyring used in the keystore. | |||
| * (client/tx) [#20870](https://github.com/cosmos/cosmos-sdk/pull/20870) Add `timeout-timestamp` field for tx body defines time based timeout.Add `WithTimeoutTimestamp` to tx factory. Increased gas cost for processing newly added timeout timestamp field in tx body. | |||
| * (client) [#21074](https://github.com/cosmos/cosmos-sdk/pull/21074) Add auto cli for node service | |||
| * (cli) [#21372](https://github.com/cosmos/cosmos-sdk/pull/21372) Add a `bulk-add-genesis-account` genesis command to add many genesis accounts at once. | |||
There was a problem hiding this comment.
Hey, can you put this under unreleased?
julienrbrt
reviewed
Aug 26, 2024
| cmd := &cobra.Command{ | ||
| Use: "bulk-add-genesis-account [/file/path.json]", | ||
| Short: "Bulk add genesis accounts to genesis.json", | ||
| Long: `Add genesis accounts in bulk to genesis.json. The provided account must specify |
There was a problem hiding this comment.
Can we add the Example field from cobra and show how the file should look like?
There was a problem hiding this comment.
x/genutil/genaccounts.go
Outdated
|
|
||
| if !vestingAmt.IsZero() { | ||
| baseVestingAccount, err := authvesting.NewBaseVestingAccount(baseAccount, vestingAmt.Sort(), vestingEnd) | ||
| accAddr, err := sdk.AccAddressFromBech32(addr) |
There was a problem hiding this comment.
Should be using address codec
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (20)
x/genutil/genaccounts.go (12)
32-35: Improve documentation for the AddGenesisAccounts function.The function documentation is clear but could benefit from additional details, such as the expected format of the
accountsparameter.Enhance the function documentation to include examples of the
accountsparameter.
42-44: Handle potential errors from GenesisStateFromGenFile more gracefully.The error handling is good, but consider providing more context in the error message to help diagnose issues.
Enhance the error message to include the
genesisFileURLfor better context.- return fmt.Errorf("failed to unmarshal genesis state: %w", err) + return fmt.Errorf("failed to unmarshal genesis state from %s: %w", genesisFileURL, err)
65-71: Improve error message for address parsing.The error message for address parsing is clear but could benefit from including the problematic address.
Enhance the error message to include the problematic address.
- return fmt.Errorf("failed to parse account address %s: %w", addr, err) + return fmt.Errorf("failed to parse account address %s: %w", addr, err)
90-93: Clarify error message for vesting amount validation.The error message for vesting amount validation is clear but could benefit from additional context.
Enhance the error message to include the account address.
- return errors.New("vesting amount cannot be greater than total amount") + return fmt.Errorf("vesting amount cannot be greater than total amount for account %s", addr)
103-104: Clarify error message for invalid vesting parameters.The error message for invalid vesting parameters is clear but could benefit from additional context.
Enhance the error message to include the account address.
- return errors.New("invalid vesting parameters; must supply start and end time or end time") + return fmt.Errorf("invalid vesting parameters for account %s; must supply start and end time or end time", addr)
111-112: Improve error message for account validation.The error message for account validation is clear but could benefit from additional context.
Enhance the error message to include the account address.
- return fmt.Errorf("failed to validate new genesis account: %w", err) + return fmt.Errorf("failed to validate new genesis account %s: %w", addr, err)
115-117: Clarify error message for existing account.The error message for existing account is clear but could benefit from additional context.
Enhance the error message to include the account address.
- return fmt.Errorf(" Account %s already exists\nUse `append` flag to append account at existing address", accAddr) + return fmt.Errorf("Account %s already exists\nUse `append` flag to append account at existing address", addr)
139-142: Improve error message for account packing.The error message for account packing is clear but could benefit from additional context.
Enhance the error message to include the account address.
- return fmt.Errorf("failed to convert accounts into any's: %w", err) + return fmt.Errorf("failed to convert accounts into any's for account %s: %w", addr, err)
144-146: Improve error message for marshaling auth genesis state.The error message for marshaling auth genesis state is clear but could benefit from additional context.
Enhance the error message to include the module name.
- return fmt.Errorf("failed to marshal auth genesis state: %w", err) + return fmt.Errorf("failed to marshal auth genesis state for module %s: %w", authtypes.ModuleName, err)
151-151: Improve error message for sanitizing genesis balances.The error message for sanitizing genesis balances is clear but could benefit from additional context.
Enhance the error message to include the module name.
- return fmt.Errorf("failed to sanitize genesis bank Balances: %w", err) + return fmt.Errorf("failed to sanitize genesis bank balances for module %s: %w", banktypes.ModuleName, err)
156-158: Improve error message for marshaling bank genesis state.The error message for marshaling bank genesis state is clear but could benefit from additional context.
Enhance the error message to include the module name.
- return fmt.Errorf("failed to marshal bank genesis state: %w", err) + return fmt.Errorf("failed to marshal bank genesis state for module %s: %w", banktypes.ModuleName, err)
Line range hint
161-163: Improve error message for marshaling application genesis state.The error message for marshaling application genesis state is clear but could benefit from additional context.
Enhance the error message to include the file path.
- return fmt.Errorf("failed to marshal application genesis state: %w", err) + return fmt.Errorf("failed to marshal application genesis state to %s: %w", genesisFileURL, err)x/genutil/client/cli/genaccount.go (8)
76-79: Improve error message for address conversion.The error message for address conversion is clear but could benefit from additional context.
Enhance the error message to include the problematic address.
- return err + return fmt.Errorf("failed to convert address %s: %w", args[0], err)
81-84: Improve error message for coin parsing.The error message for coin parsing is clear but could benefit from additional context.
Enhance the error message to include the problematic coin string.
- return err + return fmt.Errorf("failed to parse coins %s: %w", args[1], err)
86-89: Improve error message for vesting amount parsing.The error message for vesting amount parsing is clear but could benefit from additional context.
Enhance the error message to include the problematic vesting amount string.
- return err + return fmt.Errorf("failed to parse vesting amount %s: %w", vestingAmtStr, err)
102-102: Improve error message for AddGenesisAccounts.The error message for
AddGenesisAccountsis clear but could benefit from additional context.Enhance the error message to include the genesis file path.
- return genutil.AddGenesisAccounts(clientCtx.Codec, clientCtx.AddressCodec, accounts, appendflag, config.GenesisFile()) + return fmt.Errorf("failed to add genesis accounts to %s: %w", config.GenesisFile(), err)
117-119: Improve documentation for the AddBulkGenesisAccountCmd function.The function documentation is clear but could benefit from additional details, such as the expected format of the JSON file.
Enhance the function documentation to include examples of the JSON file format.
157-161: Improve error message for file opening.The error message for file opening is clear but could benefit from additional context.
Enhance the error message to include the file path.
- return fmt.Errorf("failed to open file: %w", err) + return fmt.Errorf("failed to open file %s: %w", args[0], err)
164-167: Improve error message for JSON decoding.The error message for JSON decoding is clear but could benefit from additional context.
Enhance the error message to include the file path.
- return fmt.Errorf("failed to decode JSON: %w", err) + return fmt.Errorf("failed to decode JSON from file %s: %w", args[0], err)
170-170: Improve error message for AddGenesisAccounts.The error message for
AddGenesisAccountsis clear but could benefit from additional context.Enhance the error message to include the genesis file path.
- return genutil.AddGenesisAccounts(clientCtx.Codec, clientCtx.AddressCodec, accounts, appendflag, config.GenesisFile()) + return fmt.Errorf("failed to add genesis accounts to %s: %w", config.GenesisFile(), err)
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- x/genutil/client/cli/genaccount.go (3 hunks)
- x/genutil/genaccounts.go (1 hunks)
Additional context used
Path-based instructions (2)
x/genutil/genaccounts.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/genutil/client/cli/genaccount.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Comment on lines
+18
to
+30
| type GenesisAccount struct { | ||
| // Base | ||
| Address string `json:"address"` | ||
| Coins sdk.Coins `json:"coins"` | ||
|
|
||
| // Vesting | ||
| VestingAmt sdk.Coins `json:"vesting_amt,omitempty"` | ||
| VestingStart int64 `json:"vesting_start,omitempty"` | ||
| VestingEnd int64 `json:"vesting_end,omitempty"` | ||
|
|
||
| // Module | ||
| ModuleName string `json:"module_name,omitempty"` | ||
| } |
There was a problem hiding this comment.
Ensure proper validation for GenesisAccount fields.
The GenesisAccount struct is well-defined. However, consider adding validation methods to ensure that fields like Address and Coins are valid.
Implement validation methods within the GenesisAccount struct to ensure data integrity.
Comment on lines
+55
to
+63
| newSupplyCoinsCache := sdk.NewCoins() | ||
| balanceCache := make(map[string]banktypes.Balance) | ||
| for _, acc := range accs { | ||
| for _, balance := range bankGenState.GetBalances() { | ||
| if balance.Address == acc.GetAddress().String() { | ||
| balanceCache[acc.GetAddress().String()] = balance | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Optimize balance caching logic.
The balance caching logic is correct but could be optimized by using a map for faster lookups.
Use a map to store balances for faster lookups.
- for _, acc := range accs {
- for _, balance := range bankGenState.GetBalances() {
- if balance.Address == acc.GetAddress().String() {
- balanceCache[acc.GetAddress().String()] = balance
- }
- }
- }
+ for _, balance := range bankGenState.GetBalances() {
+ balanceCache[balance.Address] = balance
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| newSupplyCoinsCache := sdk.NewCoins() | |
| balanceCache := make(map[string]banktypes.Balance) | |
| for _, acc := range accs { | |
| for _, balance := range bankGenState.GetBalances() { | |
| if balance.Address == acc.GetAddress().String() { | |
| balanceCache[acc.GetAddress().String()] = balance | |
| } | |
| } | |
| } | |
| newSupplyCoinsCache := sdk.NewCoins() | |
| balanceCache := make(map[string]banktypes.Balance) | |
| for _, balance := range bankGenState.GetBalances() { | |
| balanceCache[balance.Address] = balance | |
| } |
Comment on lines
+91
to
+100
| accounts := []genutil.GenesisAccount{ | ||
| { | ||
| Address: addrStr, | ||
| Coins: coins, | ||
| VestingAmt: vestingAmt, | ||
| VestingStart: vestingStart, | ||
| VestingEnd: vestingEnd, | ||
| ModuleName: moduleNameStr, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Ensure proper validation for GenesisAccount fields.
The GenesisAccount struct is well-defined. However, consider adding validation methods to ensure that fields like Address and Coins are valid.
Implement validation methods within the GenesisAccount struct to ensure data integrity.
raynaudoe
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
CHANGELOG.md (3)
46-46: Add missing article before "new feature".It should be "Add a
bulk-add-genesis-accountgenesis command".-* (cli) [#21372](https://github.com/cosmos/cosmos-sdk/pull/21372) Add `bulk-add-genesis-account` genesis command to add many genesis accounts at once. +* (cli) [#21372](https://github.com/cosmos/cosmos-sdk/pull/21372) Add a `bulk-add-genesis-account` genesis command to add many genesis accounts at once.
209-209: Clarify the deprecation and removal of the embedded gRPC-web proxy.The changelog entry is unclear. Is the embedded gRPC-web proxy being deprecated or completely removed? If it's being removed, suggest an alternative like using a standalone proxy.
285-287: Mention the version where the deprecated APIs will be removed.It's a good practice to mention the version where deprecated APIs will be removed to help users plan their migration.
-* (grpc) [#10985](https://github.com/cosmos/cosmos-sdk/pull/10992) The `/cosmos/tx/v1beta1/txs/{hash}` endpoint returns a 404 when a tx does not exist. +* (grpc) [#10985](https://github.com/cosmos/cosmos-sdk/pull/10992) The `/cosmos/tx/v1beta1/txs/{hash}` endpoint returns a 404 when a tx does not exist. This endpoint is deprecated and will be removed in a future release.
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (5 hunks)
Additional context used
Path-based instructions (1)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Additional comments not posted (1)
CHANGELOG.md (1)
155-157: Verify the impact of this breaking change.Removing the
.Datafield from*sdk.Resultreturned by the msg server router could break existing code that relies on this field.To verify the impact, run the following script:
Verification successful
No impact from the breaking change on existing code.
The search did not find any instances of the
.Datafield being accessed from*sdk.Resultreturned by msg server handlers. The instances found are related to protobuf-generated code and are unrelated to the msg server router. Therefore, the removal of the.Datafield should not impact the existing codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if any code is accessing the `.Data` field from `*sdk.Result` returned by msg server handlers. # Expect no results. # Search for accessing `.Data` on the result of msg server handlers rg --type go --multiline '(MsgServer|msgServer)(.|\n)*\.Data'Length of output: 63
Script:
#!/bin/bash # Re-run the search using ast-grep for a more structured search approach. ast-grep --lang go --pattern '$_.Data'Length of output: 1179
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 4b78f15) # Conflicts: # CHANGELOG.md
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 4b78f15) # Conflicts: # CHANGELOG.md # x/genutil/client/cli/commands.go # x/genutil/client/cli/genaccount.go # x/genutil/client/cli/genaccount_test.go # x/genutil/genaccounts.go
13 tasks
julienrbrt
added a commit
that referenced
this pull request
Sep 4, 2024
Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]>
julienrbrt
added a commit
that referenced
this pull request
Sep 4, 2024
Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Sep 12, 2024
…osmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]>
mmsqe
added a commit
to crypto-org-chain/cosmos-sdk
that referenced
this pull request
Sep 16, 2024
…osmos#21544) (#755) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]>
mmsqe
added a commit
to crypto-org-chain/cosmos-sdk
that referenced
this pull request
Sep 30, 2024
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <[email protected]> Co-authored-by: Julien Robert <[email protected]> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <[email protected]> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <[email protected]> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <[email protected]> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <[email protected]> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <[email protected]> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <[email protected]> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <[email protected]> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <[email protected]> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <[email protected]> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <[email protected]> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <[email protected]> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <[email protected]> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <[email protected]> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <[email protected]> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <[email protected]> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <[email protected]> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo <[email protected]> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <[email protected]> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <[email protected]> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: correct date cl v0.50.10 (cosmos#21832) * feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840) Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861) Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886) Co-authored-by: Marko <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910) Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Julien Robert <[email protected]> * align thresholdStringEncoder --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Kien <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: samricotta <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Leon <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: beer-1 <[email protected]> Co-authored-by: Shude Li <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: cocoyeal <[email protected]> Co-authored-by: PolyMa <[email protected]> Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: KI <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: lilasxie <[email protected]> Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Alexander Peters <[email protected]>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Oct 8, 2024
…osmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]>
mmsqe
added a commit
to crypto-org-chain/cosmos-sdk
that referenced
this pull request
Oct 8, 2024
…osmos#21544) (#840) * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]> * lint --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]>
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Oct 10, 2024
* fix(crypto): error if incorrect ledger public key (backport cosmos#19691) (cosmos#19745) Co-authored-by: Rootul P <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (cosmos#19751) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix: align signer extraction adapter for mempool remove (backport cosmos#19759) (cosmos#19773) Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#19706) (cosmos#19767) Co-authored-by: Richard Gibson <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#19777) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (cosmos#19770) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore(store): add release date (cosmos#19797) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <[email protected]> Co-authored-by: Julien Robert <[email protected]> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <[email protected]> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <[email protected]> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <[email protected]> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <[email protected]> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <[email protected]> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <[email protected]> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <[email protected]> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <[email protected]> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <[email protected]> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <[email protected]> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <[email protected]> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <[email protected]> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <[email protected]> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <[email protected]> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <[email protected]> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <[email protected]> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo <[email protected]> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <[email protected]> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <[email protected]> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: correct date cl v0.50.10 (cosmos#21832) * Add the sender to the InputOutputCoins transfer events. The SDK did this in PR cosmos#21460 and I undid it when merging in the v0.50.10 changes since it's more complicated for us than the SDK. So this is bringing us back in line with SDK v0.50.10 with slightly different event ordering. This change also reduces the amount of times subUnlockedCoins is called when there are multiple inputs with the same address. * Add changelog entry. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rootul P <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mmsqe <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Richard Gibson <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Cool Developer <[email protected]> Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: Kien <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: samricotta <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Leon <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: beer-1 <[email protected]> Co-authored-by: Shude Li <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: cocoyeal <[email protected]> Co-authored-by: PolyMa <[email protected]> Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: KI <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: lilasxie <[email protected]> Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: John Letey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #21340
Refactors
genutil.AddGenesisAccount(...)to allow for many accounts to be added with the newbulk-add-genesis-accountscommand. It does this by caching balances & accounts at the start, updating them in memory, then writing to disk.TODO
Get clarification on Marko's comment about vesting accounts(This is probably better scoped for a PR after this one to ensure current logic already functions as expected)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation