Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly parse json in the wait-tx command. #20631

Merged
merged 4 commits into from
Jun 13, 2024
Merged

fix: Properly parse json in the wait-tx command. #20631

merged 4 commits into from
Jun 13, 2024

Conversation

SpicyLemon
Copy link
Collaborator

@SpicyLemon SpicyLemon commented Jun 11, 2024 •
edited by coderabbitai bot
Loading

Description

This PR fixes the wait-tx command to correctly parse piped in json of a tx command. It also fixes the wait-tx examples to not append an extra d to the base command string.

The yaml parsing already worked, just not json. For JSON, it was trying to unmarshal into the wrong struct. But even if it was trying with the correct struct, it would have failed because the height field is an int64, but ends up being quoted like a string, which confuses the parser.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Bug Fixes
    • Improved JSON parsing in the wait-tx command to accurately extract the transaction hash.

@SpicyLemon SpicyLemon requested a review from a team as a code owner June 11, 2024 22:03
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 11, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes to the cosmos-sdk primarily address improvements in JSON parsing for the wait-tx command. This includes updates to the WaitTxCmd function's example formatting and enhancements in the parseHashFromInput function to accurately extract transaction hashes from JSON or YAML outputs. These modifications ensure better handling of transaction data and improve the reliability of the command.

Changes

File Change Summary
CHANGELOG.md Documented the fix related to JSON parsing in the wait-tx command as per pull request #20631.
client/rpc/tx.go Updated WaitTxCmd example formatting and improved parseHashFromInput function for better JSON handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WaitTxCmd
    participant parseHashFromInput
    participant JSON/YAML Parser

    User->>WaitTxCmd: Execute `wait-tx` command
    WaitTxCmd->>parseHashFromInput: Pass input data
    parseHashFromInput->>JSON/YAML Parser: Parse input data
    JSON/YAML Parser-->>parseHashFromInput: Return parsed transaction hash
    parseHashFromInput-->>WaitTxCmd: Return transaction hash
    WaitTxCmd-->>User: Output transaction hash
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C:CLI label Jun 11, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
coderabbitai[bot]
coderabbitai bot reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 05ff7a7 and 03cf150.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • client/rpc/tx.go (2 hunks)
Additional context used
Path-based instructions (2)
client/rpc/tx.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint
CHANGELOG.md

70-70: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

71-71: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

75-75: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

76-76: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

77-77: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

83-83: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

126-126: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

127-127: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

128-128: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

132-132: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

135-135: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

136-136: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

137-137: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

144-144: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

154-154: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

156-156: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

159-159: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

178-178: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

179-179: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

181-181: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

182-182: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

232-232: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

233-233: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

234-234: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

398-398: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

401-401: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

423-423: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

424-424: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

437-437: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

469-469: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

470-470: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

471-471: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

472-472: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

474-474: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

475-475: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

476-476: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

477-477: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

491-491: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

493-493: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

495-495: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

497-497: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

500-500: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

501-501: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

502-502: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

510-510: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

511-511: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

513-513: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

514-514: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

516-516: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

517-517: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

518-518: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

520-520: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

521-521: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

529-529: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

540-540: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

541-541: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

542-542: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

548-548: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

549-549: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

550-550: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

556-556: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

572-572: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

573-573: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

574-574: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

575-575: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

576-576: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

577-577: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

582-582: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

583-583: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

584-584: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

585-585: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

592-592: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

593-593: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

594-594: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

628-628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

629-629: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

630-630: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

631-631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

636-636: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

637-637: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

785-785: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

928-928: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

949-949: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

952-952: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1034-1034: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1035-1035: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1036-1036: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1037-1037: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1038-1038: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1039-1039: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1136-1136: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1222-1222: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1268-1268: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1274-1274: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1275-1275: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1276-1276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1277-1277: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1278-1278: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1279-1279: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1379-1379: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1504-1504: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1505-1505: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1506-1506: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1507-1507: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1508-1508: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1509-1509: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1510-1510: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1511-1511: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1514-1514: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1515-1515: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1516-1516: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1517-1517: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1518-1518: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1519-1519: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1768-1768: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1769-1769: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1770-1770: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1771-1771: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1772-1772: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1773-1773: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1883-1883: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2220-2220: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2221-2221: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2222-2222: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2225-2225: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2226-2226: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2227-2227: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2249-2249: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2250-2250: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2251-2251: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2252-2252: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2253-2253: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2261-2261: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2262-2262: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2263-2263: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2264-2264: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2265-2265: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2267-2267: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2268-2268: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2269-2269: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2596-2596: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2597-2597: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2598-2598: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2599-2599: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2600-2600: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2602-2602: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2604-2604: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2605-2605: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2607-2607: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2608-2608: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2609-2609: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2611-2611: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2612-2612: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2613-2613: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2616-2616: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2618-2618: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2619-2619: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2620-2620: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2623-2623: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2626-2626: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2629-2629: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2630-2630: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2633-2633: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2640-2640: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2641-2641: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2642-2642: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2643-2643: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2644-2644: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2646-2646: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2647-2647: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2648-2648: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2649-2649: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2650-2650: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2651-2651: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2652-2652: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2653-2653: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2654-2654: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2657-2657: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2661-2661: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2662-2662: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2669-2669: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2670-2670: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2671-2671: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2672-2672: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2679-2679: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2681-2681: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2683-2683: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2684-2684: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2685-2685: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2686-2686: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2688-2688: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2689-2689: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2690-2690: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2694-2694: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2695-2695: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2696-2696: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2697-2697: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2698-2698: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2699-2699: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2701-2701: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2702-2702: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2704-2704: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2705-2705: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2706-2706: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2707-2707: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2708-2708: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2709-2709: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2711-2711: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2712-2712: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2714-2714: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2715-2715: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2716-2716: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2717-2717: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2718-2718: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2719-2719: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2720-2720: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2723-2723: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2724-2724: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2726-2726: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2727-2727: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2730-2730: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2731-2731: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2732-2732: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2733-2733: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2734-2734: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2735-2735: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2736-2736: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2737-2737: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2739-2739: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2740-2740: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2741-2741: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2747-2747: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2750-2750: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2756-2756: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2764-2764: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2765-2765: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2766-2766: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2767-2767: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2775-2775: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2782-2782: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2783-2783: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2790-2790: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2792-2792: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2796-2796: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2797-2797: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2799-2799: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2807-2807: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2809-2809: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2810-2810: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2816-2816: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2824-2824: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2825-2825: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2826-2826: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2827-2827: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2828-2828: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2829-2829: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2830-2830: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2831-2831: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2834-2834: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2835-2835: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2836-2836: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2837-2837: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2839-2839: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2840-2840: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2842-2842: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2843-2843: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2844-2844: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2845-2845: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2846-2846: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2847-2847: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2848-2848: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2849-2849: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2850-2850: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2851-2851: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2853-2853: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2854-2854: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2857-2857: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2858-2858: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2859-2859: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2860-2860: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2861-2861: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2862-2862: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2863-2863: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2864-2864: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2865-2865: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2866-2866: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2867-2867: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2868-2868: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2869-2869: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2870-2870: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2871-2871: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2872-2872: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2877-2877: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2878-2878: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2879-2879: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2881-2881: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2882-2882: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2884-2884: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2886-2886: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2900-2900: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2901-2901: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2902-2902: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2907-2907: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2908-2908: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2909-2909: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2913-2913: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2914-2914: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2917-2917: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2918-2918: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2921-2921: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2922-2922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2923-2923: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2927-2927: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2928-2928: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2929-2929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2931-2931: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2933-2933: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2935-2935: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2940-2940: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2941-2941: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2942-2942: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2943-2943: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2944-2944: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2945-2945: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2946-2946: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2947-2947: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2948-2948: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2949-2949: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2950-2950: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2951-2951: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2952-2952: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2953-2953: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2954-2954: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2955-2955: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2956-2956: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2957-2957: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2958-2958: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2959-2959: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2960-2960: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

188-188: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

229-229: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

1138-1138: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1928-1928: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1686-1686: null (MD034, no-bare-urls)
Bare URL used

1716-1716: null (MD034, no-bare-urls)
Bare URL used

2663-2663: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2751-2751: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2753-2753: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2758-2758: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2760-2760: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2770-2770: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2772-2772: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2777-2777: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2785-2785: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2802-2802: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2804-2804: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2812-2812: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2818-2818: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2888-2888: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2891-2891: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2894-2894: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2896-2896: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2936-2936: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

1057-1057: null (MD038, no-space-in-code)
Spaces inside code span elements

2704-2704: null (MD038, no-space-in-code)
Spaces inside code span elements

2704-2704: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (2)
client/rpc/tx.go (1)

105-108: The update to use %[1]s placeholders in the example formatting is a good practice for maintainability and consistency. Well done!

CHANGELOG.md (1)

117-117: The changelog entry accurately reflects the changes made in the PR regarding JSON parsing in the wait-tx command.

client/rpc/tx.go Show resolved Hide resolved
client/rpc/tx.go Show resolved Hide resolved
@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jun 12, 2024
julienrbrt
julienrbrt approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

client/rpc/tx.go Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 03cf150 and 36dac2d.

Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (1)
CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint
CHANGELOG.md

70-70: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

71-71: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

75-75: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

76-76: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

77-77: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

83-83: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

126-126: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

127-127: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

128-128: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

132-132: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

135-135: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

136-136: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

137-137: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

144-144: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

154-154: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

156-156: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

159-159: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

178-178: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

179-179: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

181-181: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

182-182: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

233-233: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

234-234: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

235-235: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

399-399: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

402-402: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

424-424: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

425-425: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

438-438: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

470-470: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

471-471: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

472-472: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

473-473: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

475-475: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

476-476: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

477-477: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

478-478: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

492-492: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

494-494: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

496-496: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

498-498: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

501-501: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

502-502: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

503-503: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

511-511: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

512-512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

514-514: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

515-515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

517-517: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

518-518: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

519-519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

521-521: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

522-522: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

530-530: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

541-541: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

542-542: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

543-543: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

549-549: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

550-550: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

551-551: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

557-557: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

573-573: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

574-574: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

575-575: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

576-576: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

577-577: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

578-578: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

583-583: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

584-584: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

585-585: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

586-586: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

593-593: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

594-594: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

595-595: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

629-629: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

630-630: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

631-631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

632-632: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

637-637: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

638-638: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

786-786: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

929-929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

950-950: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

953-953: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1035-1035: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1036-1036: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1037-1037: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1038-1038: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1039-1039: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1040-1040: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1137-1137: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1223-1223: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1269-1269: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1275-1275: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1276-1276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1277-1277: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1278-1278: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1279-1279: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1280-1280: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1380-1380: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1505-1505: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1506-1506: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1507-1507: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1508-1508: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1509-1509: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1510-1510: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1511-1511: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1512-1512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1515-1515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1516-1516: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1517-1517: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1518-1518: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1519-1519: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1520-1520: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1769-1769: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1770-1770: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1771-1771: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1772-1772: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1773-1773: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1774-1774: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1884-1884: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2221-2221: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2222-2222: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2223-2223: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2226-2226: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2227-2227: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2228-2228: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2250-2250: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2251-2251: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2252-2252: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2253-2253: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2254-2254: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2262-2262: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2263-2263: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2264-2264: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2265-2265: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2266-2266: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2268-2268: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2269-2269: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2270-2270: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2597-2597: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2598-2598: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2599-2599: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2600-2600: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2601-2601: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2603-2603: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2605-2605: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2607-2607: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2608-2608: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2609-2609: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2610-2610: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2612-2612: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2613-2613: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2614-2614: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2618-2618: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2619-2619: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2620-2620: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2621-2621: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2624-2624: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2627-2627: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2630-2630: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2631-2631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2634-2634: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2641-2641: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2642-2642: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2643-2643: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2644-2644: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2645-2645: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2647-2647: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2648-2648: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2649-2649: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2650-2650: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2651-2651: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2652-2652: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2653-2653: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2654-2654: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2655-2655: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2661-2661: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2662-2662: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2663-2663: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2670-2670: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2671-2671: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2672-2672: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2673-2673: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2680-2680: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2682-2682: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2684-2684: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2685-2685: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2686-2686: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2688-2688: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2689-2689: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2690-2690: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2694-2694: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2695-2695: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2696-2696: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2697-2697: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2698-2698: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2699-2699: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2701-2701: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2702-2702: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2704-2704: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2705-2705: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2706-2706: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2707-2707: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2708-2708: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2709-2709: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2710-2710: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2712-2712: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2713-2713: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2715-2715: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2716-2716: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2717-2717: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2718-2718: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2719-2719: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2720-2720: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2721-2721: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2724-2724: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2725-2725: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2727-2727: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2728-2728: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2731-2731: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2732-2732: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2733-2733: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2734-2734: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2735-2735: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2736-2736: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2737-2737: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2738-2738: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2740-2740: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2741-2741: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2742-2742: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2748-2748: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2751-2751: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2757-2757: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2765-2765: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2766-2766: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2767-2767: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2768-2768: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2776-2776: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2783-2783: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2784-2784: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2791-2791: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2793-2793: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2797-2797: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2798-2798: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2800-2800: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2808-2808: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2810-2810: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2811-2811: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2817-2817: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2825-2825: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2826-2826: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2827-2827: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2828-2828: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2829-2829: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2830-2830: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2831-2831: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2834-2834: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2835-2835: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2836-2836: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2837-2837: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2838-2838: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2840-2840: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2841-2841: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2843-2843: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2844-2844: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2845-2845: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2846-2846: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2847-2847: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2848-2848: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2849-2849: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2850-2850: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2851-2851: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2852-2852: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2854-2854: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2855-2855: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2858-2858: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2859-2859: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2860-2860: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2861-2861: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2862-2862: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2863-2863: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2864-2864: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2865-2865: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2866-2866: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2867-2867: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2868-2868: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2869-2869: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2870-2870: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2871-2871: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2872-2872: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2873-2873: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2878-2878: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2879-2879: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2881-2881: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2882-2882: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2883-2883: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2885-2885: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2887-2887: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2901-2901: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2902-2902: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2903-2903: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2908-2908: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2909-2909: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2910-2910: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2914-2914: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2917-2917: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2918-2918: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2919-2919: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2922-2922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2923-2923: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2927-2927: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2928-2928: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2929-2929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2930-2930: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2932-2932: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2934-2934: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2936-2936: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2941-2941: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2942-2942: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2943-2943: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2944-2944: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2945-2945: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2946-2946: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2947-2947: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2948-2948: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2949-2949: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2950-2950: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2951-2951: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2952-2952: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2953-2953: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2954-2954: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2955-2955: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2956-2956: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2957-2957: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2958-2958: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2959-2959: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2960-2960: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2961-2961: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

188-188: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

230-230: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

1139-1139: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1929-1929: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1687-1687: null (MD034, no-bare-urls)
Bare URL used

1717-1717: null (MD034, no-bare-urls)
Bare URL used

2664-2664: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2752-2752: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2754-2754: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2759-2759: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2761-2761: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2771-2771: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2773-2773: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2778-2778: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2786-2786: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2803-2803: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2805-2805: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2813-2813: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2819-2819: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2889-2889: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2892-2892: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2895-2895: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2897-2897: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2937-2937: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

1058-1058: null (MD038, no-space-in-code)
Spaces inside code span elements

2705-2705: null (MD038, no-space-in-code)
Spaces inside code span elements

2705-2705: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (1)
CHANGELOG.md (1)

117-117: The changelog entry clearly summarizes the changes made in the PR. However, consider rephrasing for clarity and grammatical correctness.

- * [#20631](https://github.com/cosmos/cosmos-sdk/pull/20631) Fix json parsing in the wait-tx command.
+ * [#20631](https://github.com/cosmos/cosmos-sdk/pull/20631) Fixed JSON parsing in the `wait-tx` command.

@julienrbrt julienrbrt added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 55b0093 Jun 13, 2024
66 of 67 checks passed
@julienrbrt julienrbrt deleted the dwedul/fix-wait-tx branch June 13, 2024 14:18
mergify bot pushed a commit that referenced this pull request Jun 13, 2024
@SpicyLemon @mergify
fix: Properly parse json in the wait-tx command. (#20631)
abc2d08 
(cherry picked from commit 55b0093)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Jun 13, 2024
@SpicyLemon @mergify
fix: Properly parse json in the wait-tx command. (#20631)
ee1c897 
(cherry picked from commit 55b0093)

# Conflicts:
#	CHANGELOG.md
#	client/rpc/tx.go
This was referenced Jun 13, 2024
Merged
Closed
@julienrbrt julienrbrt removed the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jun 13, 2024
tac0turtle added a commit that referenced this pull request Jun 13, 2024
@mergify @SpicyLemon @tac0turtle
fix: Properly parse json in the wait-tx command. (backport #20631) (#…
ea16396 
…20660)

Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
alpe added a commit that referenced this pull request Jun 17, 2024
@alpe
Merge branch 'main' into alex/sims_runner
b74ab29 
* main:
  feat(tx): port simappv2 changes (#20648)
  build(deps): Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#20682)
  chore(proto): fix comments (#20679)
  (serverv2/cometbft) Commands support both json and yaml output (#20670)
  fix(x/staking,x/auth):  regenerate mock to fix test (#20684)
  docs: ADR 074: Msg v2 (#20618)
  fix: nested multisig signatures using CLI (#20438)
  chore: fix spelling errors (#20674)
  fix: align Dockerfile for build-push-action (#20672)
  fix: avoid build fail when make localnet-build-env (#20671)
  build(deps): Bump bufbuild/buf-setup-action from 1.32.2 to 1.33.0 (#20669)
  chore: make function comment match function names (#20666)
  chore(consensus): add cometInfo to consensus  (#20615)
  chore: fix typos (#20662)
  fix: Properly parse json in the wait-tx command. (#20631)
  fix(sims): check before sending RotateConsPubKey (#20659)
  test(types/address): add unit tests for the file types/address.go  (#20237)
Reecepbcups pushed a commit to rollchains/cosmos-sdk that referenced this pull request Jul 19, 2024
@fmorency @dependabot
@github-actions @julienrbrt @mergify @samricotta @tac0turtle @SpicyLemon @hieuvubk @facundomedica @luchenqun
chore: release 0.50.8 (#2)
a6ff246 
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590)

* docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627)

Co-authored-by: samricotta <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660)

Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711)

* feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712)

Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Facundo <[email protected]>

* feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727)

Co-authored-by: Julien Robert <[email protected]>

* docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751)

* feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897)

Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909)

Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.8 (cosmos#20910)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: samricotta <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Facundo <[email protected]>
Co-authored-by: Chenqun Lu <[email protected]>
mmsqe added a commit to crypto-org-chain/cosmos-sdk that referenced this pull request Sep 30, 2024
@mmsqe @dependabot
@github-actions @mergify @akaladarshi @tac0turtle @julienrbrt @devbull25 @yihuang @GAtom22 @lucaslopezf @facundomedica @samricotta @Reecepbcups @leonz789 @sontrinh16 @johnletey @beer-1 @islishude @damiannolan @tianyeyouyou @cocoyeal @polymaer @sergio-mena @SpicyLemon @hieuvubk @luchenqun @chipshort @czarcas7ic @KIVIKY @MSalopek @dropbigfish @lilasxie @ziscky @akhilkumarpilli @alessio @alpe
Problem: v0.50.x is outdated (#809)
f4ea363 
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844)

Co-authored-by: Aryan Tikarya <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859)

Co-authored-by: Kien <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* reuse fromAddrString (minor cleanup) (cosmos#19881)

* feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887)

* feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs(x/mint): Fix inconsistency in mint docs  (backport cosmos#19915) (cosmos#19925)

* build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001)

Co-authored-by: Julien Robert <[email protected]>

* fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008)

Co-authored-by: Tom <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017)

Co-authored-by: Lucas Francisco López <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029)

Co-authored-by: mmsqe <[email protected]>

* fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031)

Co-authored-by: Facundo Medica <[email protected]>

* fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046)

Co-authored-by: mmsqe <[email protected]>

* build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024)

* fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050)

* fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069)

Co-authored-by: Facundo Medica <[email protected]>

* build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095)

* feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.6 (cosmos#19998)

* fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111)

Co-authored-by: mmsqe <[email protected]>

* fix(x/authz,x/feegrant): check blocked address (cosmos#20102)

* chore: update v0.50.6 release notes (cosmos#20124)

* build(deps): bump sdk in modules (cosmos#20126)

* docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131)

Co-authored-by: samricotta <[email protected]>

* fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs: fix broken link (backport cosmos#20133) (cosmos#20138)

* build(deps): bump modules in simapp (cosmos#20137)

* build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152)

* docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155)

Co-authored-by: Reece Williams <[email protected]>

* fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185)

Co-authored-by: Leon <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251)

Co-authored-by: Marko <[email protected]>

* feat(baseapp): expose grpc query router via depinject. (cosmos#20264)

* feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269)

Co-authored-by: John Letey <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327)

Co-authored-by: beer-1 <[email protected]>

* fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340)

* build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338)

* style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357)

* feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383)

Co-authored-by: Shude Li <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346)

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460)

Co-authored-by: tianyeyouyou <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459)

Co-authored-by: cocoyeal <[email protected]>

* docs: update link contents (backport cosmos#20437) (cosmos#20462)

Co-authored-by: PolyMa <[email protected]>

* fix(x/consensus): harden consensus params proposal (cosmos#20381)

Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* docs: add docs on permissions (backport cosmos#20526) (cosmos#20527)

Co-authored-by: Marko <[email protected]>

* chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530)

* chore: prepare v0.50.7 (cosmos#20475)

* build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590)

* docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627)

Co-authored-by: samricotta <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660)

Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711)

* feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712)

Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Facundo <[email protected]>

* feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727)

Co-authored-by: Julien Robert <[email protected]>

* docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751)

* feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897)

Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909)

Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.8 (cosmos#20910)

* chore(simapp): use tagged version (cosmos#20951)

* fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954)

Co-authored-by: beer-1 <[email protected]>
Co-authored-by: Facundo <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970)

Co-authored-by: Julien Robert <[email protected]>

* fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973)

* fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008)

Co-authored-by: son trinh <[email protected]>

* fix(crypto): revert cosmos#20438 (cosmos#21019)

* feat: use depinject v1.0.0 (cosmos#21000)

* fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080)

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111)

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Facundo <[email protected]>

* docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154)

Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158)

* build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Facundo <[email protected]>

* chore: prepare v0.50.9 (cosmos#21163)

* ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* chore: backport NewMemStoreService method (cosmos#21212)

* build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat: module hash by height query (backport cosmos#20779) (cosmos#21247)

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268)

Co-authored-by: Tom <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Facundo <[email protected]>

* chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298)

* docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* docs: fix outdated link (backport cosmos#21397) (cosmos#21400)

Co-authored-by: KI <[email protected]>

* feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493)

Co-authored-by: MSalopek <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519)

Co-authored-by: dropbigfish <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544)

Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574)

* docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592)

* docs(client/debug): correct and improve  `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600)

Co-authored-by: lilasxie <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676)

Co-authored-by: lilasxie <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700)

Co-authored-by: Eric Mokaya <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>

* feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708)

Co-authored-by: Eric Mokaya <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724)

Co-authored-by: John Letey <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767)

* docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773)

Co-authored-by: Julien Robert <[email protected]>

* fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.10 (cosmos#21498)

* feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798)

Co-authored-by: Julien Robert <[email protected]>

* feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801)

* feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818)

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* chore: correct date cl v0.50.10 (cosmos#21832)

* feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840)

Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861)

Co-authored-by: Akhil Kumar P <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886)

Co-authored-by: Marko <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910)

Co-authored-by: Alexander Peters <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930)

Co-authored-by: John Letey <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947)

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* align thresholdStringEncoder

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Aryan Tikarya <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Kien <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Tom <[email protected]>
Co-authored-by: Lucas Francisco López <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: samricotta <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Leon <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: John Letey <[email protected]>
Co-authored-by: beer-1 <[email protected]>
Co-authored-by: Shude Li <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: tianyeyouyou <[email protected]>
Co-authored-by: cocoyeal <[email protected]>
Co-authored-by: PolyMa <[email protected]>
Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: Facundo <[email protected]>
Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: KI <[email protected]>
Co-authored-by: MSalopek <[email protected]>
Co-authored-by: dropbigfish <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: lilasxie <[email protected]>
Co-authored-by: Eric Mokaya <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>
Co-authored-by: John Letey <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Alexander Peters <[email protected]>
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Oct 10, 2024
@SpicyLemon @mergify
@rootulp @sontrinh16 @dependabot @github-actions @mmsqe @tac0turtle @gibson042 @julienrbrt @cool-develope @akaladarshi @devbull25 @yihuang @GAtom22 @lucaslopezf @facundomedica @samricotta @Reecepbcups @leonz789 @johnletey @beer-1 @islishude @damiannolan @tianyeyouyou @cocoyeal @polymaer @sergio-mena @hieuvubk @luchenqun @chipshort @czarcas7ic @KIVIKY @MSalopek @dropbigfish @lilasxie @ziscky @akhilkumarpilli
Bring in SDK changes up to v0.50.10 and Mark v0.50.10-pio-1. (#612)
6273e52 
* fix(crypto): error if incorrect ledger public key (backport cosmos#19691) (cosmos#19745)

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (cosmos#19751)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix: align signer extraction adapter for mempool remove (backport cosmos#19759) (cosmos#19773)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#19706) (cosmos#19767)

Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#19777)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (cosmos#19770)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cool Developer <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore(store): add release date (cosmos#19797)

* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844)

Co-authored-by: Aryan Tikarya <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859)

Co-authored-by: Kien <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* reuse fromAddrString (minor cleanup) (cosmos#19881)

* feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887)

* feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs(x/mint): Fix inconsistency in mint docs  (backport cosmos#19915) (cosmos#19925)

* build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001)

Co-authored-by: Julien Robert <[email protected]>

* fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008)

Co-authored-by: Tom <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017)

Co-authored-by: Lucas Francisco López <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029)

Co-authored-by: mmsqe <[email protected]>

* fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031)

Co-authored-by: Facundo Medica <[email protected]>

* fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046)

Co-authored-by: mmsqe <[email protected]>

* build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024)

* fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050)

* fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069)

Co-authored-by: Facundo Medica <[email protected]>

* build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095)

* feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.6 (cosmos#19998)

* fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111)

Co-authored-by: mmsqe <[email protected]>

* fix(x/authz,x/feegrant): check blocked address (cosmos#20102)

* chore: update v0.50.6 release notes (cosmos#20124)

* build(deps): bump sdk in modules (cosmos#20126)

* docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131)

Co-authored-by: samricotta <[email protected]>

* fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs: fix broken link (backport cosmos#20133) (cosmos#20138)

* build(deps): bump modules in simapp (cosmos#20137)

* build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152)

* docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155)

Co-authored-by: Reece Williams <[email protected]>

* fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185)

Co-authored-by: Leon <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251)

Co-authored-by: Marko <[email protected]>

* feat(baseapp): expose grpc query router via depinject. (cosmos#20264)

* feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269)

Co-authored-by: John Letey <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327)

Co-authored-by: beer-1 <[email protected]>

* fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340)

* build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338)

* style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357)

* feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366)

Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383)

Co-authored-by: Shude Li <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346)

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460)

Co-authored-by: tianyeyouyou <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459)

Co-authored-by: cocoyeal <[email protected]>

* docs: update link contents (backport cosmos#20437) (cosmos#20462)

Co-authored-by: PolyMa <[email protected]>

* fix(x/consensus): harden consensus params proposal (cosmos#20381)

Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* docs: add docs on permissions (backport cosmos#20526) (cosmos#20527)

Co-authored-by: Marko <[email protected]>

* chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530)

* chore: prepare v0.50.7 (cosmos#20475)

* build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590)

* docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627)

Co-authored-by: samricotta <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660)

Co-authored-by: Daniel Wedul <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711)

* feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712)

Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Facundo <[email protected]>

* feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727)

Co-authored-by: Julien Robert <[email protected]>

* docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751)

* feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897)

Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909)

Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.8 (cosmos#20910)

* chore(simapp): use tagged version (cosmos#20951)

* fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954)

Co-authored-by: beer-1 <[email protected]>
Co-authored-by: Facundo <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970)

Co-authored-by: Julien Robert <[email protected]>

* fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973)

* fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008)

Co-authored-by: son trinh <[email protected]>

* fix(crypto): revert cosmos#20438 (cosmos#21019)

* feat: use depinject v1.0.0 (cosmos#21000)

* fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080)

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111)

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Facundo <[email protected]>

* docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154)

Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158)

* build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Facundo <[email protected]>

* chore: prepare v0.50.9 (cosmos#21163)

* ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* chore: backport NewMemStoreService method (cosmos#21212)

* build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat: module hash by height query (backport cosmos#20779) (cosmos#21247)

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268)

Co-authored-by: Tom <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Facundo <[email protected]>

* chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298)

* docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* docs: fix outdated link (backport cosmos#21397) (cosmos#21400)

Co-authored-by: KI <[email protected]>

* feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465)

Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458)

Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493)

Co-authored-by: MSalopek <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519)

Co-authored-by: dropbigfish <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544)

Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541)

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574)

* docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592)

* docs(client/debug): correct and improve  `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600)

Co-authored-by: lilasxie <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676)

Co-authored-by: lilasxie <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700)

Co-authored-by: Eric Mokaya <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>

* feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708)

Co-authored-by: Eric Mokaya <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724)

Co-authored-by: John Letey <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>

* docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767)

* docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773)

Co-authored-by: Julien Robert <[email protected]>

* fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771)

Co-authored-by: Julien Robert <[email protected]>

* chore: prepare v0.50.10 (cosmos#21498)

* feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798)

Co-authored-by: Julien Robert <[email protected]>

* feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801)

* feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818)

Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: marbar3778 <[email protected]>

* chore: correct date cl v0.50.10 (cosmos#21832)

* Add the sender to the InputOutputCoins transfer events. The SDK did this in PR cosmos#21460 and I undid it when merging in the v0.50.10 changes since it's more complicated for us than the SDK. So this is bringing us back in line with SDK v0.50.10 with slightly different event ordering. This change also reduces the amount of times subUnlockedCoins is called when there are multiple inputs with the same address.

* Add changelog entry.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: sontrinh16 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: marbar3778 <[email protected]>
Co-authored-by: Richard Gibson <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Cool Developer <[email protected]>
Co-authored-by: Aryan Tikarya <[email protected]>
Co-authored-by: Kien <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Tom <[email protected]>
Co-authored-by: Lucas Francisco López <[email protected]>
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: samricotta <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Leon <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: John Letey <[email protected]>
Co-authored-by: beer-1 <[email protected]>
Co-authored-by: Shude Li <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: tianyeyouyou <[email protected]>
Co-authored-by: cocoyeal <[email protected]>
Co-authored-by: PolyMa <[email protected]>
Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: Facundo <[email protected]>
Co-authored-by: Chenqun Lu <[email protected]>
Co-authored-by: Christoph Otter <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: KI <[email protected]>
Co-authored-by: MSalopek <[email protected]>
Co-authored-by: dropbigfish <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: lilasxie <[email protected]>
Co-authored-by: Eric Mokaya <[email protected]>
Co-authored-by: Akhil Kumar P <[email protected]>
Co-authored-by: John Letey <[email protected]>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica facundomedica approved these changes

Assignees

@lucaslopezf lucaslopezf

@facundomedica facundomedica

@julienrbrt julienrbrt

Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpicyLemon @facundomedica @julienrbrt @lucaslopezf