Baseserver send #203
Closed
Baseserver send #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After offline emails and a video call with @ethanfrey, a goal was decided to move things around i.e: - [X] Move /build/send and /query/account to modules/coin/rest Due to that move, there is a lot of overlap between needed code and utils so extracted common code to make tendermint/tmlibs#33 so make sure to pull in that commit into your tmlibs tree. After code review feedback: client/rest, modules/coin/rest: FoutputProof, PrepareSendTx helper * Extract OutputProof to FoutputProof helper that can be used in modules/coin/rest/handlers.go as proofs.FoutputProof * Revert r.HandleFunc("/tx", doPostTx).Methods("POST") which was erraneously deleted * Use function signatures from "tendermint/tmblibs/common"
Implemented /send which sends an amount directly from one account to another Fixes #102
|
Closing this. Once /login works, let's take another stab at it. I like the idea, just want to clean up the approach. |
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
alexanderbez
added a commit
that referenced
this pull request
May 26, 2022
* Add proto for Clawback Vesting Account * Change field to int * Change field to int64 * add place holder for clawback * add handler and basic msgs methods * add clawback vesting account logic * improvements * fix: Dev/clawback test debug (#198) * add tests * add clawback before starttime test * clean imports * Printlns for the clawback testing * Fix tests and logic * Fix the gas exhaustion vuln * Remove printlns * Delete extraneous account set * chore: add table driven test cases to clawback (#199) * add table driven tests * Modify test cases * More detail in error message * Update x/auth/vesting/types/vesting_account_test.go * Update x/auth/vesting/types/vesting_account_test.go Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]> * fix: cherry pick agoric's cosmos sdk#207 (#203) * cherry pick compute endtime fix * Merge branch 'osmosis-main' into mattverse/clawback Co-authored-by: mattverse <[email protected]> Co-authored-by: Matt, Park <[email protected]> * feat: add clawback cli and tests (#207) * add clawback cli and tests * Update x/auth/vesting/client/cli/tx.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update x/auth/vesting/client/cli/tx.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update x/auth/vesting/client/cli/tx.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * minor fix * Minor fix * Update x/auth/vesting/client/cli/cli_test.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Change from code review from Alex and Dev Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
sbellem
pushed a commit
to initc3/cosmos-sdk
that referenced
this pull request
Jan 27, 2023
Fix Amino for authz for good
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this pull request
Feb 29, 2024
Problem: GHSA-86h5-xcpx-cfqc is not merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, and also waiting for #197 to be merged, hence the first seemingly spurious commit.