add .editorconfig #178
Closed
add .editorconfig #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
suggested changes
Jul 19, 2017
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [Makefile] |
There was a problem hiding this comment.
This seems to contradict https://github.com/tendermint/coding/blob/master/Coding_Standard.md#non-golang-code
which requests 4 spaces per tab. which is also what rigel is doing... reformatting all my code.
|
Please re-open this when a standard is found in other repos. I like the idea and will follow any conventions that the organization decides, but cannot evaluate it. |
|
This is essentially the standard. It is the same file in tendermint and ethermint. |
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
## Description Closes: #178 Adds the requested differential language between auth and authz modules. Resolves instances of future tense that were noticed. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [NA] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [NA] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [NA] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [NA] added a changelog entry to `CHANGELOG.md` - [NA] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [NA] reviewed "Files changed" and left comments if necessary - [NA] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
mattverse
referenced
this pull request
in mattverse/cosmos-sdk
Apr 20, 2022
feat: min and max operators on coins
alexanderbez
added a commit
that referenced
this pull request
May 26, 2022
* Add proto for Clawback Vesting Account * Change field to int * Change field to int64 * add place holder for clawback * add handler and basic msgs methods * add clawback vesting account logic * improvements * fix: Dev/clawback test debug (#198) * add tests * add clawback before starttime test * clean imports * Printlns for the clawback testing * Fix tests and logic * Fix the gas exhaustion vuln * Remove printlns * Delete extraneous account set * chore: add table driven test cases to clawback (#199) * add table driven tests * Modify test cases * More detail in error message * Update x/auth/vesting/types/vesting_account_test.go * Update x/auth/vesting/types/vesting_account_test.go Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Dev Ojha <[email protected]> * fix: cherry pick agoric's cosmos sdk#207 (#203) * cherry pick compute endtime fix * Merge branch 'osmosis-main' into mattverse/clawback Co-authored-by: mattverse <[email protected]> Co-authored-by: Matt, Park <[email protected]> * feat: add clawback cli and tests (#207) * add clawback cli and tests * Update x/auth/vesting/client/cli/tx.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update x/auth/vesting/client/cli/tx.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update x/auth/vesting/client/cli/tx.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> * minor fix * Minor fix * Update x/auth/vesting/client/cli/cli_test.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Change from code review from Alex and Dev Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
sontrinh16
pushed a commit
to sontrinh16/cosmos-sdk
that referenced
this pull request
Nov 14, 2023
MalteHerrmann
pushed a commit
to MalteHerrmann/cosmos-sdk
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.