-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/staking): migrate redelegation key to use collections #17315
Conversation
…ion-key-to-collections
…ion-key-to-collections
…ion-key-to-collections
…s/cosmos-sdk into ap/redelegation-key-to-collections
…ion-key-to-collections
…s/cosmos-sdk into ap/redelegation-key-to-collections
…s/cosmos-sdk into ap/redelegation-key-to-collections
…ion-key-to-collections
…ion-key-to-collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, a comment regarding a function that might not be in use. Have you run the diff colls test?
x/staking/keeper/delegation.go
Outdated
@@ -293,22 +293,18 @@ func (k Keeper) IterateDelegatorDelegations(ctx context.Context, delegator sdk.A | |||
|
|||
// IterateDelegatorRedelegations iterates through one delegator's redelegations. | |||
func (k Keeper) IterateDelegatorRedelegations(ctx context.Context, delegator sdk.AccAddress, cb func(red types.Redelegation) (stop bool)) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being used in any other part of the code? Looks like it's not
Why do we need |
…ion-key-to-collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can look into removing GetREDByValDstIndexKey and GetREDByValSrcIndexKey to use this same collection later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Closes: #16383
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change