Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): Migrate UnbondingDelegationByValIndex to use collections #17291

Merged
merged 63 commits into from
Aug 30, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #16385


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review August 7, 2023 11:36
@likhita-809 likhita-809 requested a review from a team as a code owner August 7, 2023 11:36
@github-prbot github-prbot requested review from a team, alexanderbez and julienrbrt and removed request for a team August 7, 2023 11:36
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused, UnbondingDelegationByValIndex is not being used to Set anywhere, but I think it should be used in SetUnbondingDelegation and RemoveUnbondingDelegation. Also it should not be a collections.Map but a collections.KeySet

@facundomedica facundomedica added this pull request to the merge queue Aug 30, 2023
Merged via the queue into main with commit 3ed40a9 Aug 30, 2023
@facundomedica facundomedica deleted the likhita/ubdValIndex-coll branch August 30, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(staking): move UnbondingDelegationByValIndex to use collections
7 participants