-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/staking): Migrate UnbondingDelegationByValIndex to use collections #17291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ita/ubdValIndex-coll
…ita/ubdValIndex-coll
…ita/ubdValIndex-coll
github-prbot
requested review from
a team,
alexanderbez and
julienrbrt
and removed request for
a team
August 7, 2023 11:36
…ita/ubdValIndex-coll
julienrbrt
reviewed
Aug 8, 2023
facundomedica
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused, UnbondingDelegationByValIndex
is not being used to Set
anywhere, but I think it should be used in SetUnbondingDelegation
and RemoveUnbondingDelegation
. Also it should not be a collections.Map but a collections.KeySet
likhita-809
force-pushed
the
likhita/ubdValIndex-coll
branch
from
August 29, 2023 07:54
562cc23
to
f1be944
Compare
github-actions
bot
removed
C:CLI
C:Store
C:x/auth
C:x/evidence
C:x/upgrade
C:x/feegrant
C:Cosmovisor
Issues and PR related to Cosmovisor
C:x/nft
C:orm
C:collections
C:Confix
Issues and PR related to Confix
C:x/circuit
C:Hubl
Tool: Hubl
C:x/accounts
labels
Aug 29, 2023
…ita/ubdValIndex-coll
…ita/ubdValIndex-coll
…ita/ubdValIndex-coll
…ita/ubdValIndex-coll
…ita/ubdValIndex-coll
facundomedica
approved these changes
Aug 30, 2023
12 tasks
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16385
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change