Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocli): add map support #15770
feat(autocli): add map support #15770
Changes from 23 commits
608b657
c772f7e
b1f39e1
62b594a
909d497
19bc662
194f1ec
4af8805
5a2a220
2ecdd0e
f63e841
8bd224e
3f537c6
4602c67
063e6f0
e3bfa29
3c17f9b
d16f02c
0a3037d
b47085e
4390236
ca99ce3
eebaa3f
314b2b9
af82b18
4b3f018
773c092
1d72109
2bd4af4
8f3c45c
de46fd9
ff5114f
f35af11
f3cf0d2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary, please just return
return strconv.ParseBool(s)
or even betterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @odeke-em could you provide me with some guidance on how to handle this error?
Cannot use 'strconv.ParseBool' (type func(str string) (bool, error)) as the type func(string) (K, error)
In order to make this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyParser: strconv.ParseBool,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyParser: strconv.ParseBool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary casts and redundancy, please simply return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyParser: strconv.ParseBool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyParser: strconv.ParseBool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyParser: strconv.ParseBool