feat(autocli): add map support #15770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
aaronc and
tac0turtle
and removed request for
a team
|
@JeancarloBarrios your pull request is missing a changelog! |
JeancarloBarrios
requested review from
a team and
julienrbrt
and removed request for
tac0turtle and
a team
…cosmos-sdk into JeancarloBarrios/cli-map-support
julienrbrt
reviewed
May 23, 2023
Comment on lines
+30
to
+32
| --map-string-coin map[string]cosmos.base.v1beta1.Coin some map of string to coin | ||
| --map-string-string stringToString some map of string to string (default []) | ||
| --map-string-uint32 stringToUint32 some map of string to int32 |
There was a problem hiding this comment.
This still needs to be updated.
…cosmos-sdk into JeancarloBarrios/cli-map-support
julienrbrt
approved these changes
May 26, 2023
|
|
||
| type keyValueResolver[T comparable] func(string) (T, error) | ||
|
|
||
| type compositeMapType[T comparable] struct { |
There was a problem hiding this comment.
it will be nice to add a go doc to these.
julienrbrt
reviewed
May 26, 2023
JeancarloBarrios
added
the
A:automerge
…cosmos-sdk into JeancarloBarrios/cli-map-support
JeancarloBarrios
removed
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #13290
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change