feat: SigVerificationDecorator ante handler with x/tx legacy amino json sign mode handler #15713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
…k into kocubinski/sigverify-v2
… into kocubinski/x-tx-decode
… into kocubinski/x-tx-decode
kocubinski
changed the title
kocubinski
commented
Apr 10, 2023
| @@ -21,7 +21,9 @@ type StdSignMsg struct { | |||
|
|
|||
| // get message bytes | |||
| func (msg StdSignMsg) Bytes() []byte { | |||
There was a problem hiding this comment.
This function appears to unused but is exported, can it be removed to fully deprecate StdSignBytes?
This comment has been minimized.
This comment has been minimized.
…k into kocubinski/sigverify-v2
kocubinski
commented
Apr 11, 2023
| @@ -46,7 +46,7 @@ func marshalTimestamp(message protoreflect.Message, writer io.Writer) error { | |||
|
|
|||
| // MaxDurationSeconds the maximum number of seconds (when expressed as nanoseconds) which can fit in an int64. | |||
| // gogoproto encodes google.protobuf.Duration as a time.Duration, which is 64-bit signed integer. | |||
| const MaxDurationSeconds = int64(math.MaxInt64/int(1e9)) - 1 | |||
| const MaxDurationSeconds = int64(math.MaxInt64)/1e9 - 1 | |||
There was a problem hiding this comment.
Since math.MaxInt64 is an untyped constant, an explicit cast is required to support 32 arch, e.g. our arm docker builds. See golang/go#23086.
This was surfaced bringing latest x/tx into simapp builds.
kocubinski
force-pushed
the
kocubinski/sigverify-v2
branch
from
17175ce
to
fe98dac
Compare
kocubinski
added a commit
that referenced
this pull request
Apr 12, 2023
|
Is #15822 an alternative to this or are these complementary? |
This should be probably be closed now.. it's an alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #15698
Includes: #15414
This patch deprecates calls to legacytx.StdSignBytes and therefore calls to LegacyMsg.GetSignBytes.
In the default ante handler a new code path is introduced by opting into the x/tx SignModeHandler by setting
ante.HandlerOptions.SignModeHandlerV2. This could also be an API break onHandlerOptions.SignModeHandlerif we choose to do so.The usage of
StdSignBytesin client/tx is a straightforward refactor to depend on x/tx signers.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change