Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SigVerificationDecorator AnteHandler to use x/tx legacy amino json sign mode #15698

Closed
1 task done
kocubinski opened this issue Apr 4, 2023 · 0 comments · Fixed by #15822
Closed
1 task done
Assignees

Comments

@kocubinski
Copy link
Member

kocubinski commented Apr 4, 2023

Summary

Now that #15170 is completed we should migrate SigVerificationDecorator ante handler to use the new code.

Problem Definition

Once this is done we should be able to fully deprecate/break usages of GetSignBytes. This pattern is an obstacle to resolving cyclic module dependencies in x/auth and elsewhere. A global codec.LegacyAmino ref is initialized in an init() in modules. The sole reason for this seems to be the implementations of LegacyMsg.GetSignBytes, e.g. auth.MsgUpdateParams.

Implementing this will improve overall code quality (no globals) and move us closer to the longstanding goal of separating SDK modules into independent go modules - #11899.

Proposal

Integrate the legacy amino json sign mode in #15515 into SigVerificationDecorator.

Requires:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants