-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gRPC query for operator and chain configuration #13485
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13485 +/- ##
==========================================
- Coverage 53.90% 53.81% -0.10%
==========================================
Files 642 653 +11
Lines 55452 56828 +1376
==========================================
+ Hits 29893 30581 +688
- Misses 23155 23801 +646
- Partials 2404 2446 +42
|
// RegisterGRPCGatewayRoutes mounts the node gRPC service's GRPC-gateway routes | ||
// on the given mux object. | ||
func RegisterGRPCGatewayRoutes(clientConn gogogrpc.ClientConn, mux *runtime.ServeMux) { | ||
_ = RegisterServiceHandlerClient(context.Background(), mux, NewServiceClient(clientConn)) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I wouldn't put node and chain configuration together.
Account prefixes in my mind should be exposed by the auth query services and the validator prefixes should be exposed by staking. The fact that there is still the global config is not something we should rely on here as it could go away and I think those prefixes would go to auth and staking modules.
Why are we exposing bech32 pub key prefixes? I thought those were deprecated.
Also regarding node minimum gas price, this makes sense and this location looks good, but it seems that clients won't actually get the gas prices of validators but sentries or full nodes right?
I think it's so silly to separate Bech32 HRPs like this. It makes zero sense to me. They really don't belong in any module IMO.
I exposed whatever was in
What clients can do is query public nodes to get a good understanding of what the average min gas price is. At the end of the day, yes, it's the proposer's min gas price that matters. In any case, since I'm getting push back on the bech32 stuff, I'm just going to keep the min gas price field. |
* fix: move ics23 to correct folder (cosmos#13549) * fix: fix liveness tests cosmos#13551 * feat: add `GenSignedMockTx` (cosmos#13557) * fix: fix `make proto-gen` (cosmos#13564) * fix: fix `make proto-gen` * add changelog * feat: [REDO] gRPC query for operator and chain configuration (backport cosmos#13485) (cosmos#13589) * chore: bump tendermint to `0.34.22` (cosmos#13585) * fix: (v0.45.x) regression in return value of WithdrawDelegationRewards when rewards are zero (cosmos#13588) * fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. (cosmos#13610) * Populate the PruningKeepEvery config entry in GetConfig. * Update changlog. * feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13617) * feat(cli): add module-account cli cmd and grpc get api (cosmos#13612) (cherry picked from commit ddf5cf0) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/query.pulsar.go # api/cosmos/auth/v1beta1/query_grpc.pb.go # proto/cosmos/auth/v1beta1/query.proto # tests/e2e/auth/suite.go # x/auth/client/cli/query.go # x/auth/keeper/grpc_query.go # x/auth/keeper/grpc_query_test.go # x/auth/types/query.pb.go # x/auth/types/query.pb.gw.go * update changelog * fix conflicts Co-authored-by: Sai Kumar <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare 0.45.10 changelog (cosmos#13624) * chore: prepare 0.45.10 changelog * default release notes * period * Add missing changelog section for v0.45.9-pio-1. * Remove the old release notes. * Remove accidentally duplicated section for v0.45.4. * Add new v0.45.10-pio-1 section to the changelog and update the release notes to reflect our stuff. * Include a 'nothing' under unreleased. * Add links to changlog entries. Co-authored-by: Aaron Craelius <[email protected]> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Nick DeLuca <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Sai Kumar <[email protected]>
…cosmos#13485) (cosmos#13589) (cherry picked from commit 7a500a2)
…s#13485) (cosmos#13497) * feat: gRPC query for operator and chain configuration (cosmos#13485) (cherry picked from commit c60c556) # Conflicts: # CHANGELOG.md # UPGRADING.md # api/cosmos/auth/v1beta1/query_grpc.pb.go # api/cosmos/bank/v1beta1/query.pulsar.go # runtime/app.go # server/start.go # simapp/app_legacy.go # x/bank/types/query.pb.go * updates * updates * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Description
Closes: #11582
Introduce a new
/cosmos/base/node/v1beta1/config
gRPC query that exposes operator configuration, most notably the operator's configured minimum gas price.I added the proto definition to a new
proto/cosmos/base/node/v1beta1/query.proto
path, as I could not find a more fitting place. Open to suggestions on alternatives, but I'm pretty happy with this location.I've marked this for backport to 0.45.x and 0.46.x, even though it technically breaks the
Application
Go API, but I think this is worth it since so many folks have requested this for a variety of reasons.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change