Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Complete Setup to not take in a testing parameter #1325

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Refactor Complete Setup to not take in a testing parameter #1325

merged 2 commits into from
Jun 21, 2018

Conversation

ValarDragon
Copy link
Contributor

@ValarDragon ValarDragon commented Jun 21, 2018 •
edited by cwgoes
Loading

Resolves #1323

  • Updated all relevant documentation in docs - n/a
  • Updated all code comments where relevant -n/a
  • Wrote tests - n/a
  • Updated CHANGELOG.md
  • Updated Gaia/Examples -n/a
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards) - n/a (single commit)

@ValarDragon ValarDragon requested a review from cwgoes June 21, 2018 07:37
@ValarDragon ValarDragon requested a review from ebuchman as a code owner June 21, 2018 07:37
@codecov
Copy link

codecov bot commented Jun 21, 2018 •
edited
Loading

Codecov Report

Merging #1325 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #1325   +/-   ##
========================================
  Coverage    65.28%   65.28%           
========================================
  Files          102      102           
  Lines         5533     5533           
========================================
  Hits          3612     3612           
  Misses        1712     1712           
  Partials       209      209

cwgoes
cwgoes approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit e2d2304 into develop Jun 21, 2018
@cwgoes cwgoes deleted the dev/refactor_complete_setup branch June 21, 2018 16:55
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@ValarDragon
Merge PR #1325: Refactor Complete Setup to not take in a testing para…
ccf99ac 
…meter

* Refactor Complete Setup to not take in a testing parameter
* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @cwgoes