Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/auth/mock: Refactor CompleteSetup to not take in t *testing.T #1323

Closed
ValarDragon opened this issue Jun 21, 2018 · 0 comments
Closed

x/auth/mock: Refactor CompleteSetup to not take in t *testing.T #1323

ValarDragon opened this issue Jun 21, 2018 · 0 comments
Labels
good first issue T: Tests

Comments

@ValarDragon
Copy link
Contributor

Currently the function type signature is: func (app *App) CompleteSetup(t *testing.T, newKeys []*sdk.KVStoreKey)

I propose changing this to func (app *App) CompleteSetup(newKeys []*sdk.KVStoreKey) Error.
The reason for changing this is that we can then use mock apps for benchmarking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue T: Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ValarDragon