Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename depinject imports to cosmossdk.io/depinject #12479

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #11905


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt force-pushed the julien/depinject-go-mod branch from ac66b68 to 8b3c60c Compare July 9, 2022 14:52
@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #12479 (8b3c60c) into main (411c272) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12479      +/-   ##
==========================================
+ Coverage   65.54%   65.91%   +0.37%     
==========================================
  Files         687      702      +15     
  Lines       71707    72940    +1233     
==========================================
+ Hits        46998    48078    +1080     
- Misses      22058    22174     +116     
- Partials     2651     2688      +37     
Impacted Files Coverage Δ
core/appconfig/config.go 74.02% <ø> (ø)
depinject/config.go 85.88% <ø> (ø)
depinject/container.go 90.40% <ø> (ø)
depinject/debug.go 96.49% <ø> (ø)
depinject/group.go 80.00% <ø> (ø)
depinject/module_dep.go 92.30% <ø> (ø)
depinject/one_per_module.go 73.07% <ø> (ø)
depinject/simple.go 100.00% <ø> (ø)
depinject/supply.go 81.81% <ø> (ø)
simapp/app.go 69.01% <ø> (ø)
... and 34 more

@julienrbrt julienrbrt merged commit 52bc0c1 into main Jul 9, 2022
@julienrbrt julienrbrt deleted the julien/depinject-go-mod branch July 9, 2022 15:46
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename container go module cosmossdk.io/depinject
2 participants