Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename container go module cosmossdk.io/depinject #11905

Closed
3 tasks done
Tracked by #11899
aaronc opened this issue May 9, 2022 · 6 comments · Fixed by #12479
Closed
3 tasks done
Tracked by #11899

Rename container go module cosmossdk.io/depinject #11905

aaronc opened this issue May 9, 2022 · 6 comments · Fixed by #12479
Assignees
@julienrbrt

Comments

@aaronc
Copy link
Member

aaronc commented May 9, 2022 •
edited
Loading

  • setup vanity URL
  • refactor code
  • tag
@aaronc aaronc mentioned this issue May 9, 2022
Closed
81 tasks
@aaronc aaronc changed the title Rename container module cosmossdk.io/container Rename container go module cosmossdk.io/container May 9, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 9, 2022
@aaronc aaronc mentioned this issue May 11, 2022
Closed
@aaronc
Copy link
Member Author

aaronc commented May 11, 2022

I think maybe we should rename this away from container

The name does not feel super-intuitive to me. It could be any sort of container like a map or list data type. The fact that it is a dependency injection container is not obvious.

Maybe we can think of something better when we move to cosmossdk.io?

@alexanderbez
Copy link
Contributor

What do you have in mind?

@aaronc
Copy link
Member Author

aaronc commented May 11, 2022

What do you have in mind?

No idea. Was hoping someone had a good name

@facundomedica facundomedica mentioned this issue May 23, 2022
Merged
19 tasks
@facundomedica
Copy link
Member

Renaming to depinject as discussed in #12020

@aaronc aaronc changed the title Rename container go module cosmossdk.io/container Rename container go module cosmossdk.io/depinject May 31, 2022
@aaronc
Copy link
Member Author

aaronc commented May 31, 2022

Tagged https://github.com/cosmos/cosmos-sdk/releases/tag/depinject%2Fv1.0.0-alpha.1

@aaronc aaronc closed this as completed May 31, 2022
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK May 31, 2022
@aaronc
Copy link
Member Author

aaronc commented Jul 7, 2022 •
edited
Loading

Reopening this because the depinject go.mod still says github.com/cosmos/cosmos-sdk/depinject. This should be a quick PR. Can somebody take this on?

@aaronc aaronc reopened this Jul 7, 2022
Repository owner moved this from 👏 Done to 📝 Todo in Cosmos-SDK Jul 7, 2022
@julienrbrt julienrbrt mentioned this issue Jul 7, 2022
Merged
19 tasks
Repository owner moved this from 📝 Todo to 👏 Done in Cosmos-SDK Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
None yet
Projects
Cosmos-SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename depinject imports to cosmossdk.io/depinject cosmos/cosmos-sdk
5 participants
@aaronc @alexanderbez @facundomedica @tac0turtle @julienrbrt