Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testutil network app config setup #12254

Closed
wants to merge 6 commits into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 14, 2022

Description

This fixes an issue uncovered in #12243 where testutil/network validators share the same app instance.

It also fixes the signature of runtime.AppBuilder.Build which requires passing back the MsgServiceRouter that runtime already created.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -29,15 +29,14 @@ func (a *AppBuilder) Build(
logger log.Logger,
db dbm.DB,
traceStore io.Writer,
msgServiceRouter *baseapp.MsgServiceRouter,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to resolve this and then pass this parameter back into Build. runtime created it in the first place

@aaronc aaronc marked this pull request as ready for review June 14, 2022 17:51
@aaronc aaronc requested a review from a team as a code owner June 14, 2022 17:51
testutil/network/network.go Outdated Show resolved Hide resolved
testutil/network/network.go Outdated Show resolved Hide resolved
aaronc and others added 3 commits June 14, 2022 13:57
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 14, 2022
@likhita-809
Copy link
Contributor

The changes from here are cleanly merged into main as a part of #12243
Closing this since there are no other new changes.

@julienrbrt julienrbrt deleted the aaronc/fix-network-app-config branch June 15, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants