Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x/group app wiring integration tests #12243

Merged
merged 37 commits into from
Jun 15, 2022

Conversation

likhita-809
Copy link
Contributor

Description

ref: #12024


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Jun 14, 2022
Base automatically changed from likhita/group-app-wiring to main June 14, 2022 16:17
aaronc and others added 3 commits June 14, 2022 13:57
@aaronc aaronc marked this pull request as ready for review June 14, 2022 21:18
@aaronc aaronc requested a review from a team as a code owner June 14, 2022 21:18
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #12243 (8a2ab88) into main (d705a8b) will decrease coverage by 0.00%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12243      +/-   ##
==========================================
- Coverage   66.10%   66.09%   -0.01%     
==========================================
  Files         674      674              
  Lines       71155    71154       -1     
==========================================
- Hits        47034    47032       -2     
- Misses      21480    21481       +1     
  Partials     2641     2641              
Impacted Files Coverage Δ
testutil/network/network.go 56.67% <0.00%> (-0.13%) ⬇️
simapp/app.go 72.72% <100.00%> (-0.26%) ⬇️

@mergify mergify bot merged commit bfb91ab into main Jun 15, 2022
@mergify mergify bot deleted the likhita/group-integration-app-wiring branch June 15, 2022 05:31
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
## Description

ref: cosmos#12024 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants