-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename container.Option to container.Config #12021
Conversation
91c78f9
to
dbbe9d3
Compare
Codecov Report
@@ Coverage Diff @@
## main #12021 +/- ##
==========================================
+ Coverage 66.09% 66.42% +0.32%
==========================================
Files 671 685 +14
Lines 70950 71925 +975
==========================================
+ Hits 46894 47774 +880
- Misses 21399 21467 +68
- Partials 2657 2684 +27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trait doesn't seem clearer to me than Option. For lack of anything I've seen that's better I'd say let's go with Config. At least it's better than Option and not otherwise confusing (I think)
dc648cf
to
b5a2139
Compare
Also no need to rebase, we always squash anyways |
@kocubinski once you have two approvals and you're ready to merge, you can add the auto merge label |
Description
Ref: #11917
The noun should be one which conveys the notion of a core instruction. Other names for this type I've considered:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change