Consider renaming container.Option #11917
Assignees
Comments
81 tasks
|
+1 on EDIT: nvm, I'm not sure on this one after looking more into the code. |
|
How about |
19 tasks
|
Sort of leaning towards |
mergify bot
pushed a commit
that referenced
this issue
May 24, 2022
## Description Ref: #11917 The noun should be one which conveys the notion of a *core instruction*. Other names for this type I've considered: - Instruction - Behavior - Specification - [Config](#11917 (comment)) (probably the most straighforward) - Trait --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Repository owner
moved this from 📝 Todo
to 👏 Done
in Cosmos-SDK
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When working with the container,
Optionseems like a weird name for what this does. It's really the core set of instructions to build the container. MaybeConfigorInitializer?The text was updated successfully, but these errors were encountered: