fix: Add validation on create gentx #11693

anilcse · 2022-04-20T05:44:39Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…tor_gentx

alexanderbez

LGTM! Left a few minor remarks. We also need a changelog entry 👍

x/genutil/client/testutil/suite.go

alexanderbez · 2022-04-20T13:06:50Z

Should we backport this @anilcse?

anilcse · 2022-04-20T13:55:24Z

Should we backport this @anilcse?

Yes, we should. There are a few tests failing, I am still looking into them. will update and re-request a review

alexanderbez · 2022-04-20T14:13:09Z

Ok! Can you add the appropriate backport labels too please?

…to anil/refactor_gentx

anilcse · 2022-04-20T14:35:55Z

x/genutil/gentx_test.go

@@ -231,7 +231,7 @@ func (suite *GenTxTestSuite) TestDeliverGenTxs() {
 			"success",
 			func() {
 				_ = suite.setAccountBalance(addr1, 50)
-				_ = suite.setAccountBalance(addr2, 0)
+				_ = suite.setAccountBalance(addr2, 1)


previously, amount was hard coded here

codecov · 2022-04-20T14:47:25Z

Codecov Report

Merging #11693 (51d3843) into master (1042373) will increase coverage by 0.00%.
The diff coverage is 96.73%.

@@           Coverage Diff           @@
##           master   #11693   +/-   ##
=======================================
  Coverage   65.92%   65.92%           
=======================================
  Files         667      667           
  Lines       70446    70462   +16     
=======================================
+ Hits        46441    46455   +14     
- Misses      21307    21309    +2     
  Partials     2698     2698

Impacted Files	Coverage Δ
types/coin.go	`93.11% <ø> (ø)`
x/genutil/client/cli/gentx.go	`0.00% <0.00%> (ø)`
x/genutil/client/testutil/suite.go	`100.00% <100.00%> (ø)`
crypto/keys/internal/ecdsa/privkey.go	`84.21% <0.00%> (+1.75%)`	⬆️

(cherry picked from commit df61142) # Conflicts: # CHANGELOG.md

(cherry picked from commit df61142) # Conflicts: # CHANGELOG.md # x/genutil/client/cli/gentx.go # x/genutil/client/testutil/suite.go # x/genutil/gentx_test.go

alexanderbez · 2022-04-20T14:58:56Z

@anilcse would you mind addressing the conflicts on the backport PRs? They should be pretty minor.

* check error returned from NewNode (cosmos#11624) * docs: Add v0.45.x to docs versions (backport cosmos#11613) (cosmos#11623) * docs: Update mentions of Starport to Ignite CLI (backport cosmos#11612) (cosmos#11617) * feat: add (re)delegation getters (backport cosmos#11596) (cosmos#11615) * feat: add (re)delegation getters (cosmos#11596) ### Description This PR adds general helper functions to the `x/staking` module that are used in the Evmos `x/vesting` module and originated from Agoric's custom staking module implementation https://github.com/agoric-labs/cosmos-sdk/blob/4085-true-vesting/x/staking/keeper/delegation.go. - `GetDelegatorUnbonding` - `GetDelegatorBonded` - `IterateDelegatorUnbondingDelegations` - `IterateDelegatorDelegations` - `IterateDelegatorRedelegations` (cherry picked from commit b8270fc) # Conflicts: # CHANGELOG.md # x/staking/keeper/delegation.go * fix RemoveDelegation method conflict * fix CHANGELOG conflict * add new PR in CHANGELOG Co-authored-by: Daniel Burckhardt <[email protected]> * feat: add vesting util functions (backport cosmos#11652) (cosmos#11667) * feat: add vesting util functions (cosmos#11652) * feat: add vesting util functions * changelog * revert string deletion * fix build * Update x/auth/vesting/types/period.go Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Marko <[email protected]> (cherry picked from commit c676952) # Conflicts: # CHANGELOG.md # x/auth/vesting/types/period.go * changelog * Update x/auth/vesting/types/period.go Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * chore: v0.45.x bump min go version to 1.17 (cosmos#11686) * fix: Add validation on create gentx (backport cosmos#11693) (cosmos#11698) * fix: Added description of how to run the unsafe-reset-all command in simapp README (cosmos#11718) (cosmos#11719) * Fix simapp README * Revised review content Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit d5e0b86) Co-authored-by: Takahiko Tominaga <[email protected]> * chore: remove unneeded swagger docs from 0.45 cosmos#11745 * fix: data race issues with api.Server (backport cosmos#11724) (cosmos#11748) * updates (cosmos#11750) * updates (cosmos#11752) * chore: release notes++ * Add dynamic build tag so this can build on M1 macs. * Change README line endings to dos since that's what they were originally. Co-authored-by: Jorge Hernandez <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Takahiko Tominaga <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>

…1698)

anilcse added 3 commits April 1, 2022 00:48

use test amount

62a9219

Merge branch 'master' of github.com:cosmos/cosmos-sdk into anil/refac…

e1bcfc0

…tor_gentx

validate gentx on creation

266b6a5

anilcse requested review from aaronc and alexanderbez as code owners April 20, 2022 05:44

github-actions bot added C:CLI C:x/genutil genutil module issues labels Apr 20, 2022

anilcse added 2 commits April 20, 2022 11:29

add test

43b3168

cleanup tests

4a4341a

anilcse requested review from aleem1314, amaury1093 and atheeshp April 20, 2022 06:44

anilcse changed the title ~~Fix: Add validation on create gentx~~ fix: Add validation on create gentx Apr 20, 2022

Merge branch 'master' into anil/refactor_gentx

83bf590

alexanderbez reviewed Apr 20, 2022

View reviewed changes

x/genutil/client/testutil/suite.go Outdated Show resolved Hide resolved

x/genutil/client/testutil/suite.go Outdated Show resolved Hide resolved

Merge branch 'master' into anil/refactor_gentx

62f3ca9

anilcse added 4 commits April 20, 2022 19:54

cleanup

f153312

Fix tests

439faa8

Merge branch 'anil/refactor_gentx' of github.com:cosmos/cosmos-sdk in…

2be2b49

…to anil/refactor_gentx

add change log

3802a2f

anilcse commented Apr 20, 2022

View reviewed changes

anilcse requested a review from alexanderbez April 20, 2022 14:36

anilcse added backport/0.44.x backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Apr 20, 2022

Merge branch 'master' into anil/refactor_gentx

51d3843

blushi assigned JeancarloBarrios Apr 20, 2022

blushi assigned likhita-809 Apr 20, 2022

alexanderbez approved these changes Apr 20, 2022

View reviewed changes

alexanderbez merged commit df61142 into master Apr 20, 2022

alexanderbez deleted the anil/refactor_gentx branch April 20, 2022 14:54

mergify bot pushed a commit that referenced this pull request Apr 20, 2022

fix: Add validation on create gentx (#11693)

682a602

(cherry picked from commit df61142) # Conflicts: # CHANGELOG.md

mergify bot mentioned this pull request Apr 20, 2022

fix: Add validation on create gentx (backport #11693) #11697

Merged

mergify bot pushed a commit that referenced this pull request Apr 20, 2022

fix: Add validation on create gentx (#11693)

68cd8c3

(cherry picked from commit df61142) # Conflicts: # CHANGELOG.md # x/genutil/client/cli/gentx.go # x/genutil/client/testutil/suite.go # x/genutil/gentx_test.go

mergify bot mentioned this pull request Apr 20, 2022

fix: Add validation on create gentx (backport #11693) #11698

Merged

mergify bot pushed a commit that referenced this pull request Apr 20, 2022

fix: Add validation on create gentx (#11693)

718a71e

(cherry picked from commit df61142) # Conflicts: # CHANGELOG.md # x/genutil/client/cli/gentx.go # x/genutil/client/testutil/suite.go # x/genutil/gentx_test.go

mergify bot mentioned this pull request Apr 20, 2022

fix: Add validation on create gentx (backport #11693) #11699

Merged

alexanderbez pushed a commit that referenced this pull request Apr 20, 2022

fix: Add validation on create gentx (backport #11693) (#11697)

e4a0cb2

alexanderbez pushed a commit that referenced this pull request Apr 20, 2022

fix: Add validation on create gentx (backport #11693) (#11698)

13d78de

alexanderbez pushed a commit that referenced this pull request Apr 20, 2022

fix: Add validation on create gentx (backport #11693) (#11699)

d759237

JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022

fix: Add validation on create gentx (backport cosmos#11693) (cosmos#1…

38b79bf

…1698)

randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022

fix: Add validation on create gentx (backport cosmos#11693) (cosmos#1…

97f8c2a

…1698)

JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024

fix: Add validation on create gentx (backport cosmos#11693) (cosmos#1…

c468d12

…1698)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add validation on create gentx #11693

fix: Add validation on create gentx #11693

anilcse commented Apr 20, 2022

alexanderbez left a comment

alexanderbez commented Apr 20, 2022

anilcse commented Apr 20, 2022

alexanderbez commented Apr 20, 2022

anilcse Apr 20, 2022

codecov bot commented Apr 20, 2022 •

edited

Loading

alexanderbez commented Apr 20, 2022

fix: Add validation on create gentx #11693

fix: Add validation on create gentx #11693

Conversation

anilcse commented Apr 20, 2022

Description

Author Checklist

Reviewers Checklist

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez commented Apr 20, 2022

anilcse commented Apr 20, 2022

alexanderbez commented Apr 20, 2022

anilcse Apr 20, 2022

Choose a reason for hiding this comment

codecov bot commented Apr 20, 2022 • edited Loading

Codecov Report

alexanderbez commented Apr 20, 2022

codecov bot commented Apr 20, 2022 •

edited

Loading