Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: v0.45.x bump min go version to 1.17 #11686

Merged
merged 6 commits into from
Apr 19, 2022
Merged

chore: v0.45.x bump min go version to 1.17 #11686

merged 6 commits into from
Apr 19, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Closes: #11684

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez requested a review from aaronc as a code owner April 19, 2022 13:27
@alexanderbez alexanderbez changed the title updates chore: v0.45.x bump min go version to 1.17 Apr 19, 2022
amaury1093
amaury1093 approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth a changelog entry

@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Apr 19, 2022
fedekunze
fedekunze approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏 👏 👏 👏

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 19, 2022
@alexanderbez
Copy link
Contributor Author

I need to handle any other traces of 1.15 before merging...

@github-actions github-actions bot added the T: CI label Apr 19, 2022
@alexanderbez alexanderbez merged commit ffef0ba into release/v0.45.x Apr 19, 2022
@alexanderbez alexanderbez deleted the bez/bump-go-min branch April 19, 2022 18:01
@crodriguezvega crodriguezvega mentioned this pull request Apr 22, 2022
Closed
4 tasks
dwedul-figure added a commit to provenance-io/cosmos-sdk that referenced this pull request May 19, 2022
@dwedul-figure @jhernandezb
@mergify @danburck @fedekunze @alexanderbez @takapi327 @tac0turtle
Merge v0.45.4 into PIO 0.45.x (#127)
9b10c37 
* check error returned from NewNode (cosmos#11624)

* docs: Add v0.45.x to docs versions (backport cosmos#11613) (cosmos#11623)

* docs: Update mentions of Starport to Ignite CLI (backport cosmos#11612) (cosmos#11617)

* feat: add (re)delegation getters (backport cosmos#11596) (cosmos#11615)

* feat: add (re)delegation getters (cosmos#11596)

### Description

This PR adds general helper functions to the `x/staking` module that are used in the Evmos `x/vesting` module and originated from Agoric's custom staking module implementation https://github.com/agoric-labs/cosmos-sdk/blob/4085-true-vesting/x/staking/keeper/delegation.go.

- `GetDelegatorUnbonding`
- `GetDelegatorBonded`
- `IterateDelegatorUnbondingDelegations`
- `IterateDelegatorDelegations`
- `IterateDelegatorRedelegations`

(cherry picked from commit b8270fc)

# Conflicts:
#	CHANGELOG.md
#	x/staking/keeper/delegation.go

* fix RemoveDelegation method conflict

* fix CHANGELOG conflict

* add new PR in CHANGELOG

Co-authored-by: Daniel Burckhardt <[email protected]>

* feat: add vesting util functions (backport cosmos#11652) (cosmos#11667)

* feat: add vesting util functions (cosmos#11652)

* feat: add vesting util functions

* changelog

* revert string deletion

* fix build

* Update x/auth/vesting/types/period.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Marko <[email protected]>
(cherry picked from commit c676952)

# Conflicts:
#	CHANGELOG.md
#	x/auth/vesting/types/period.go

* changelog

* Update x/auth/vesting/types/period.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>

* chore: v0.45.x bump min go version to 1.17 (cosmos#11686)

* fix: Add validation on create gentx (backport cosmos#11693) (cosmos#11698)

* fix: Added description of how to run the unsafe-reset-all command in simapp README (cosmos#11718) (cosmos#11719)

* Fix simapp README

* Revised review content

Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit d5e0b86)

Co-authored-by: Takahiko Tominaga <[email protected]>

* chore: remove unneeded swagger docs from 0.45 cosmos#11745

* fix: data race issues with api.Server (backport cosmos#11724) (cosmos#11748)

* updates (cosmos#11750)

* updates (cosmos#11752)

* chore: release notes++

* Add dynamic build tag so this can build on M1 macs.

* Change README line endings to dos since that's what they were originally.

Co-authored-by: Jorge Hernandez <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Takahiko Tominaga <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
JimLarson pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Jul 7, 2022
@alexanderbez @JimLarson
chore: v0.45.x bump min go version to 1.17 (cosmos#11686)
be76a6a
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
@alexanderbez @randy75828
chore: v0.45.x bump min go version to 1.17 (cosmos#11686)
9cfe1b3
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@alexanderbez @JeancarloBarrios
chore: v0.45.x bump min go version to 1.17 (cosmos#11686)
6de5884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@anilcse anilcse anilcse approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Rosetta Issues and PR related to Rosetta T: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @amaury1093 @anilcse @fedekunze