-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metadata field to Vote in x/gov #11308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likhita-809
changed the title
Likhita/gov add metadata to vote
feat: Add metadata field to Vote in x/gov
Mar 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #11308 +/- ##
==========================================
- Coverage 65.98% 65.93% -0.06%
==========================================
Files 696 662 -34
Lines 71310 68527 -2783
==========================================
- Hits 47055 45180 -1875
+ Misses 21340 20702 -638
+ Partials 2915 2645 -270
|
…khita/gov-add-metadata-to-vote
likhita-809
requested review from
amaury1093,
atheeshp,
aleem1314,
anilcse and
blushi
March 2, 2022 10:24
anilcse
reviewed
Mar 2, 2022
atheeshp
reviewed
Mar 2, 2022
amaury1093
reviewed
Mar 2, 2022
…khita/gov-add-metadata-to-vote
amaury1093
approved these changes
Mar 3, 2022
anilcse
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
amaury1093
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Mar 3, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
C:Simulations
C:x/auth
C:x/gov
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11268
Add metadata to Vote in x/gov using the existing maxMetadataLen constraint.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change