Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reason field to every governance vote #11373

Closed
4 tasks
ValarDragon opened this issue Mar 14, 2022 · 4 comments
Closed
4 tasks

Add a reason field to every governance vote #11373

ValarDragon opened this issue Mar 14, 2022 · 4 comments
Labels

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented Mar 14, 2022

Summary

Governance votes should have a "reason" string field, that could then be displayed by explorers or other governance tooling. The reason field length doesn't need to big, it could be parameterized such that its expected to link to an external site. (So perhaps 128 bytes)

The reason field should be required for validator votes. At worst they can spam it and its not that big of a deal.

Problem Definition

We are in a bad social standard, where most validators are voting without providing a reason. I actually had a github issue (or maybe github comment) from cosmos-prelaunch where we wanted to do this. It was closed, because someone predicted that validators would fill it with spam. I still think this should be re-added, and if its filled with spam thats ok. Its auditable that the validator chose to not provide a reason!

Imo this is a significant improvement to expecting more from validators in votes. If its not desired in the cosmos-SDK, will likely go ahead and implement it in Osmosis.

Proposal

Add a reason string field to governance votes. Make it required for validators to include a reason of at least say 10 characters. (But fully optional for non-validators)

cc @sunnya97


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@aaronc
Copy link
Member

aaronc commented Mar 14, 2022

Partially closed by #11308. If you want to make it required for validators, feel free to open a follow-up PR. Requiring validators to specify a reason though should probably be a gov param so chains could disable it

@ValarDragon
Copy link
Contributor Author

Seems like we need to make a planned structure for the metadata field to use it as a reason, right?

Can't just have many different ad-hoc formats in use, and make explorers deal with them all. Seems like theres really only three use cases here though: "reason as a string", or "reason as a URL pointing to another site", or "reason as a reference pointing to another on-chain data object".

@aaronc
Copy link
Member

aaronc commented Mar 15, 2022

We are working on that in coordination with a gov frontend. @nooomski @cmwaters any details you can share?

@tac0turtle
Copy link
Member

@ValarDragon are you fine with the metadata field here as reasoning. It seems like it's fine since its a string and can be arbitrary like a reason field would be.

Closing this for now, please reopen if something else is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants