Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: messed up api proto-gen #10902

Merged
merged 3 commits into from
Jan 11, 2022
Merged

fix: messed up api proto-gen #10902

merged 3 commits into from
Jan 11, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 6, 2022

Description

seems like I didn't get the pulsar alpha6 protogen right in #10669


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #10902 (e8a8fda) into master (0cb7fd0) will decrease coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10902      +/-   ##
==========================================
- Coverage   64.87%   64.68%   -0.20%     
==========================================
  Files         628      610      -18     
  Lines       59689    58774     -915     
==========================================
- Hits        38722    38016     -706     
+ Misses      18770    18619     -151     
+ Partials     2197     2139      -58     
Impacted Files Coverage Δ
x/auth/middleware/fee.go 80.00% <50.00%> (-0.91%) ⬇️
store/types/gas.go 84.44% <100.00%> (ø)
x/auth/middleware/middleware.go 73.21% <100.00%> (+0.99%) ⬆️
orm/encoding/ormkv/index_key.go
orm/encoding/ormkv/seq.go
orm/encoding/ormfield/timestamp.go
orm/encoding/ormkv/primary_key.go
orm/encoding/ormfield/int64.go
orm/encoding/ormkv/key_codec.go
... and 13 more

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do you have to bump the version in the go.mod

@fdymylja
Copy link
Contributor

fdymylja commented Jan 7, 2022

But why are all the gRPC interfaces getting removed?

@aaronc
Copy link
Member Author

aaronc commented Jan 7, 2022

But why are all the gRPC interfaces getting removed?

I have no idea. So is pulsar supposed to generate gRPC interfaces? I thought we had to use grpc-go

@atheeshp
Copy link
Contributor

atheeshp commented Jan 10, 2022

Is this related to fix the make proto-gen issue?

@fdymylja
Copy link
Contributor

But why are all the gRPC interfaces getting removed?

I have no idea. So is pulsar supposed to generate gRPC interfaces? I thought we had to use grpc-go

pulsar should not generate gprc - only proto messages.

we need to use grpc-go to generate grpc stuff. it should even be in a different file.

we maybe need to add the grpc plugin to buf?

for instance, we need to generate gprc stuff to allow clients to query things in the chain.

@aaronc
Copy link
Member Author

aaronc commented Jan 10, 2022

But why are all the gRPC interfaces getting removed?

I have no idea. So is pulsar supposed to generate gRPC interfaces? I thought we had to use grpc-go

pulsar should not generate gprc - only proto messages.

we need to use grpc-go to generate grpc stuff. it should even be in a different file.

we maybe need to add the grpc plugin to buf?

for instance, we need to generate gprc stuff to allow clients to query things in the chain.

That's what I thought. I can add that to this PR

@aaronc
Copy link
Member Author

aaronc commented Jan 10, 2022

Is this related to fix the make proto-gen issue?

which make proto-gen issue?

@aaronc
Copy link
Member Author

aaronc commented Jan 10, 2022

Just added grpc codegen in api/

Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but let's merge it for now.

Will be experimenting to see if all works and will create issues accordingly!

Thank you @aaronc

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jan 10, 2022
@aaronc
Copy link
Member Author

aaronc commented Jan 10, 2022

Not tested, but let's merge it for now.

Will be experimenting to see if all works and will create issues accordingly!

Thank you @aaronc

Thanks @fdymylja 👍

@mergify mergify bot merged commit d64253f into master Jan 11, 2022
@mergify mergify bot deleted the aaronc/fix-api-proto-gen branch January 11, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants