-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: messed up api proto-gen #10902
fix: messed up api proto-gen #10902
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10902 +/- ##
==========================================
- Coverage 64.87% 64.68% -0.20%
==========================================
Files 628 610 -18
Lines 59689 58774 -915
==========================================
- Hits 38722 38016 -706
+ Misses 18770 18619 -151
+ Partials 2197 2139 -58
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, do you have to bump the version in the go.mod
But why are all the gRPC interfaces getting removed? |
I have no idea. So is pulsar supposed to generate gRPC interfaces? I thought we had to use grpc-go |
Is this related to fix the |
pulsar should not generate gprc - only proto messages. we need to use grpc-go to generate grpc stuff. it should even be in a different file. we maybe need to add the grpc plugin to buf? for instance, we need to generate gprc stuff to allow clients to query things in the chain. |
That's what I thought. I can add that to this PR |
which make proto-gen issue? |
Just added grpc codegen in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested, but let's merge it for now.
Will be experimenting to see if all works and will create issues accordingly!
Thank you @aaronc
Description
seems like I didn't get the pulsar alpha6 protogen right in #10669
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change