feat: full api module building alongside gogo proto files with buf schema registry support #10669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10669 +/- ##
==========================================
- Coverage 64.91% 64.87% -0.05%
==========================================
Files 632 628 -4
Lines 59901 59689 -212
==========================================
- Hits 38885 38722 -163
+ Misses 18816 18770 -46
+ Partials 2200 2197 -3
|
aaronc
changed the title
github-actions
bot
added
C:CLI
C:Cosmovisor
github-actions
bot
removed
C:CLI
C:Store
C:Cosmovisor
tac0turtle
reviewed
Jan 5, 2022
fdymylja
approved these changes
Jan 6, 2022
tac0turtle
approved these changes
Jan 6, 2022
fdymylja
suggested changes
Jan 6, 2022
|
Once cosmos/cosmos-proto#56 is merged and protofiles are rebuilt I think we can merge this... Good we caught this bug though... |
tac0turtle
reviewed
Jan 6, 2022
| cd proto | ||
| proto_dirs=$(find ./cosmos -path -prune -o -name '*.proto' -print0 | xargs -0 -n1 dirname | sort | uniq) | ||
| for dir in $proto_dirs; do | ||
| for file in $(find "${dir}" -maxdepth 1 -name '*.proto'); do |
There was a problem hiding this comment.
do you need this for loop? for reference in tendermint we do https://github.com/tendermint/tendermint/blob/master/scripts/protocgen.sh#L32
There was a problem hiding this comment.
it is needed because we only generate proto files with a go_package option explicitly specified with gogo, and we run grep on each file to figure that out. if no go_package is set we assume it is pulsar only
|
Updated this code with your pulsar fix @fdymylja |
fdymylja
approved these changes
Jan 6, 2022
|
I guess let's merge this 🎉 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2022
## Description seems like I didn't get the pulsar alpha6 protogen right in #10669 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This was referenced Jan 28, 2022
19 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following changes:
apimodule has pulsar/golang v2 code generation applied to all cosmos and tendermint proto files including new proto files which are never had nor will have a gogo proto representation. The buf managed mode is used for this generationthird_party/proto/tendermintis moved toproto/tendermintand made part of the "cosmos" proto API (@marbar3778 let's coordinate on applying versioning)confioproto files were removed (not used)gogoproto,googleapisproto types are now retrieved as buf schema registry dependenciesAll of the cosmos-sdk proto files are now present in the buf schema registry with auto-generated documentation here: https://buf.build/cosmos/cosmos-sdk
The main files to look at here are
protocgen.shand the variousbuf.yamlfiles.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change