Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use go 1.17 style go.mod file #10063

Closed
wants to merge 6 commits into from
Closed

fix: use go 1.17 style go.mod file #10063

wants to merge 6 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 2, 2021

Description

Closes: nothing

This upgrades the SDK to use the go 1.17 module format, which is much cleaner. If we want to do this, let me know, and I can add these changes to all of the modules in the SDK as well.

@ValarDragon identified the multiple tendermint issue.

Go1.17 makes it easier to see things like the multiple tendermint issue addressed in #10062


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat changed the title 117 fix: use go 1.17 style go.mod file Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #10063 (65b1ed2) into master (eb0113e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10063      +/-   ##
==========================================
- Coverage   63.58%   63.58%   -0.01%     
==========================================
  Files         572      572              
  Lines       53584    53586       +2     
==========================================
+ Hits        34074    34075       +1     
- Misses      17565    17566       +1     
  Partials     1945     1945              
Impacted Files Coverage Δ
types/coin.go 93.64% <100.00%> (+0.03%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need bump Go version's in our Ci workflows?

@alexanderbez
Copy link
Contributor

@alessio ?

@alessio
Copy link
Contributor

alessio commented Sep 10, 2021

@alessio ?

Yes we do need bumping all ci requirements

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update ci requirements accordingly

@robert-zaremba
Copy link
Collaborator

cosmovisor/go.mod should be updated as well.

@robert-zaremba robert-zaremba mentioned this pull request Sep 10, 2021
19 tasks
@fedekunze
Copy link
Collaborator

dup from #9987

@amaury1093
Copy link
Contributor

fixed by #9987

@amaury1093 amaury1093 closed this Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants