-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use go 1.17 style go.mod file #10063
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10063 +/- ##
==========================================
- Coverage 63.58% 63.58% -0.01%
==========================================
Files 572 572
Lines 53584 53586 +2
==========================================
+ Hits 34074 34075 +1
- Misses 17565 17566 +1
Partials 1945 1945
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need bump Go version's in our Ci workflows?
@alessio ? |
Yes we do need bumping all ci requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update ci requirements accordingly
cosmovisor/go.mod should be updated as well. |
dup from #9987 |
fixed by #9987 |
Description
Closes: nothing
This upgrades the SDK to use the go 1.17 module format, which is much cleaner. If we want to do this, let me know, and I can add these changes to all of the modules in the SDK as well.
@ValarDragon identified the multiple tendermint issue.
Go1.17 makes it easier to see things like the multiple tendermint issue addressed in #10062
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change