Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'basecli keys new' should have an --unsafe flag #213

Closed
zramsay opened this issue Aug 7, 2017 · 4 comments
Closed

'basecli keys new' should have an --unsafe flag #213

zramsay opened this issue Aug 7, 2017 · 4 comments

Comments

@zramsay
Copy link
Contributor

zramsay commented Aug 7, 2017

for easier scripting/testing/tutorialing

This was referenced Aug 7, 2017
@ethanfrey
Copy link
Contributor

And what would this unsafe flag do?

@zramsay
Copy link
Contributor Author

zramsay commented Aug 7, 2017

not require a password & not return a seed phrase (because sometimes you don't care). it's probably overkill though, especially since the pipes work nicely as is

@ethanfrey
Copy link
Contributor

ethanfrey commented Aug 8, 2017

There is a flag to not return a seed. You can see it in help.
eg. basecli keys new johnny --no-backup

No password seems bad. But I don't necessarily need to enforce 10 characters. I could lower it if it makes things easier and leave it to people to choose their security level.

@zramsay If I only enforce a 4 character minimum password, would that resolve this issue? (along with documenting/using the other flag)

@zramsay
Copy link
Contributor Author

zramsay commented Aug 8, 2017

naw, I just use the top row of number. Let's not clutter the cli

@zramsay zramsay closed this as completed Aug 8, 2017
liamsi pushed a commit to liamsi/cosmos-sdk that referenced this issue Jun 26, 2018
* move from tmlibs 213
* expose KVPair, simpleproofsfrommap returns keys
ParthDesai pushed a commit to ChorusOne/cosmos-sdk that referenced this issue Apr 19, 2021
Thunnini pushed a commit to Thunnini/cosmos-sdk that referenced this issue May 15, 2022
alexanderbez added a commit that referenced this issue May 26, 2022
…mit flow (#213)

* fix: simulation and grpc query concurrency with ABCI

* table tests for selectHeight

* add table-driven GRPC query tests and fix non-existent heights

* clean up

* clean up grpc query tests

* Apply suggestions from code review

* Update testutil/network/network.go

* fix typo in abci.go

* Update baseapp/abci.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* store last block height in a var

* avoid returning named parameters

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
roysc pushed a commit to vulcanize/cosmos-sdk that referenced this issue Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants